From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 1/2] Code cleanup: New symbol_filename_ftype
Date: Fri, 10 Jun 2011 21:24:00 -0000 [thread overview]
Message-ID: <20110610212400.GH12834@adacore.com> (raw)
In-Reply-To: <20110610202912.GA31746@host1.jankratochvil.net>
> I will check it in less than a week.
I'd just go ahead and check in now. Patches like these are great, IMO.
Note that it gives us an opportunity to document the meaning of the
various parameters (I am also a fan of naming the parameters in
declarations as well, as Jan did here).
> gdb/
> 2011-06-10 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Code cleanup.
> * dwarf2read.c (dw2_map_symbol_filenames): Use symbol_filename_ftype
> for fun.
> * psymtab.c (map_symbol_filenames_psymtab)
> (map_partial_symbol_filenames): Likewise.
> * psymtab.h: Include symfile.h.
> (map_partial_symbol_filenames): Use symbol_filename_ftype for fun.
> * symfile.h (symbol_filename_ftype): New.
> (struct quick_symbol_functions): Use symbol_filename_ftype for fun of
> map_symbol_filenames, clarify more the naming in comment.
Looks good to me.
--
Joel
prev parent reply other threads:[~2011-06-10 21:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 20:29 Jan Kratochvil
2011-06-10 20:55 ` Tom Tromey
2011-06-10 21:58 ` Jan Kratochvil
2011-06-10 21:24 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110610212400.GH12834@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox