From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 482 invoked by alias); 10 Jun 2011 21:24:27 -0000 Received: (qmail 473 invoked by uid 22791); 10 Jun 2011 21:24:26 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jun 2011 21:24:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F12232BB5F4; Fri, 10 Jun 2011 17:24:07 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ePq1zZJAHuMr; Fri, 10 Jun 2011 17:24:07 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C56072BB5F3; Fri, 10 Jun 2011 17:24:07 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1D59F145615; Fri, 10 Jun 2011 14:24:00 -0700 (PDT) Date: Fri, 10 Jun 2011 21:24:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 1/2] Code cleanup: New symbol_filename_ftype Message-ID: <20110610212400.GH12834@adacore.com> References: <20110610202912.GA31746@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110610202912.GA31746@host1.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00143.txt.bz2 > I will check it in less than a week. I'd just go ahead and check in now. Patches like these are great, IMO. Note that it gives us an opportunity to document the meaning of the various parameters (I am also a fan of naming the parameters in declarations as well, as Jan did here). > gdb/ > 2011-06-10 Jan Kratochvil > > Code cleanup. > * dwarf2read.c (dw2_map_symbol_filenames): Use symbol_filename_ftype > for fun. > * psymtab.c (map_symbol_filenames_psymtab) > (map_partial_symbol_filenames): Likewise. > * psymtab.h: Include symfile.h. > (map_partial_symbol_filenames): Use symbol_filename_ftype for fun. > * symfile.h (symbol_filename_ftype): New. > (struct quick_symbol_functions): Use symbol_filename_ftype for fun of > map_symbol_filenames, clarify more the naming in comment. Looks good to me. -- Joel