* [RFA] remove unused(?) code in tramp_frame_cache
@ 2010-03-04 18:14 Doug Evans
2010-03-04 19:07 ` Daniel Jacobowitz
0 siblings, 1 reply; 2+ messages in thread
From: Doug Evans @ 2010-03-04 18:14 UTC (permalink / raw)
To: gdb-patches
Hi.
I was going to check this in as obvious, but I couldn't
discount the possibility that the call to get_frame_pc was
being done for possible side effects.
I don't have a target to test this on.
Does this look ok?
2010-03-04 Doug Evans <dje@google.com>
* tramp-frame.c (tramp_frame_cache): Delete unused code.
Index: tramp-frame.c
===================================================================
RCS file: /cvs/src/src/gdb/tramp-frame.c,v
retrieving revision 1.18
diff -u -p -r1.18 tramp-frame.c
--- tramp-frame.c 1 Jan 2010 07:31:43 -0000 1.18
+++ tramp-frame.c 4 Mar 2010 18:05:38 -0000
@@ -44,7 +44,6 @@ static struct trad_frame_cache *
tramp_frame_cache (struct frame_info *this_frame,
void **this_cache)
{
- CORE_ADDR pc = get_frame_pc (this_frame);
struct tramp_frame_cache *tramp_cache = (*this_cache);
if (tramp_cache->trad_cache == NULL)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFA] remove unused(?) code in tramp_frame_cache
2010-03-04 18:14 [RFA] remove unused(?) code in tramp_frame_cache Doug Evans
@ 2010-03-04 19:07 ` Daniel Jacobowitz
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Jacobowitz @ 2010-03-04 19:07 UTC (permalink / raw)
To: Doug Evans; +Cc: gdb-patches
On Thu, Mar 04, 2010 at 10:13:57AM -0800, Doug Evans wrote:
> Hi.
>
> I was going to check this in as obvious, but I couldn't
> discount the possibility that the call to get_frame_pc was
> being done for possible side effects.
> I don't have a target to test this on.
>
> Does this look ok?
Yes, this is fine.
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-04 19:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-04 18:14 [RFA] remove unused(?) code in tramp_frame_cache Doug Evans
2010-03-04 19:07 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox