From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30371 invoked by alias); 4 Mar 2010 18:14:06 -0000 Received: (qmail 30363 invoked by uid 22791); 4 Mar 2010 18:14:05 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Mar 2010 18:14:01 +0000 Received: from spaceape10.eur.corp.google.com (spaceape10.eur.corp.google.com [172.28.16.144]) by smtp-out.google.com with ESMTP id o24IDxl6009040 for ; Thu, 4 Mar 2010 10:13:59 -0800 Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.18.118.116]) by spaceape10.eur.corp.google.com with ESMTP id o24IDv1S003767 for ; Thu, 4 Mar 2010 10:13:58 -0800 Received: by ruffy.mtv.corp.google.com (Postfix, from userid 67641) id 90D838484B; Thu, 4 Mar 2010 10:13:57 -0800 (PST) To: gdb-patches@sourceware.org Subject: [RFA] remove unused(?) code in tramp_frame_cache Message-Id: <20100304181357.90D838484B@ruffy.mtv.corp.google.com> Date: Thu, 04 Mar 2010 18:14:00 -0000 From: dje@google.com (Doug Evans) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00202.txt.bz2 Hi. I was going to check this in as obvious, but I couldn't discount the possibility that the call to get_frame_pc was being done for possible side effects. I don't have a target to test this on. Does this look ok? 2010-03-04 Doug Evans * tramp-frame.c (tramp_frame_cache): Delete unused code. Index: tramp-frame.c =================================================================== RCS file: /cvs/src/src/gdb/tramp-frame.c,v retrieving revision 1.18 diff -u -p -r1.18 tramp-frame.c --- tramp-frame.c 1 Jan 2010 07:31:43 -0000 1.18 +++ tramp-frame.c 4 Mar 2010 18:05:38 -0000 @@ -44,7 +44,6 @@ static struct trad_frame_cache * tramp_frame_cache (struct frame_info *this_frame, void **this_cache) { - CORE_ADDR pc = get_frame_pc (this_frame); struct tramp_frame_cache *tramp_cache = (*this_cache); if (tramp_cache->trad_cache == NULL) {