Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [RFA] remove unused(?) code in tramp_frame_cache
Date: Thu, 04 Mar 2010 18:14:00 -0000	[thread overview]
Message-ID: <20100304181357.90D838484B@ruffy.mtv.corp.google.com> (raw)

Hi.

I was going to check this in as obvious, but I couldn't
discount the possibility that the call to get_frame_pc was
being done for possible side effects.
I don't have a target to test this on.

Does this look ok?

2010-03-04  Doug Evans  <dje@google.com>

	* tramp-frame.c (tramp_frame_cache): Delete unused code.

Index: tramp-frame.c
===================================================================
RCS file: /cvs/src/src/gdb/tramp-frame.c,v
retrieving revision 1.18
diff -u -p -r1.18 tramp-frame.c
--- tramp-frame.c	1 Jan 2010 07:31:43 -0000	1.18
+++ tramp-frame.c	4 Mar 2010 18:05:38 -0000
@@ -44,7 +44,6 @@ static struct trad_frame_cache *
 tramp_frame_cache (struct frame_info *this_frame,
 		   void **this_cache)
 {
-  CORE_ADDR pc = get_frame_pc (this_frame);
   struct tramp_frame_cache *tramp_cache = (*this_cache);
   if (tramp_cache->trad_cache == NULL)
     {


             reply	other threads:[~2010-03-04 18:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04 18:14 Doug Evans [this message]
2010-03-04 19:07 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100304181357.90D838484B@ruffy.mtv.corp.google.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox