* PATCH: PR tui/9622: tui over-eagerly initializes readline
@ 2010-02-04 17:07 H.J. Lu
2010-02-04 17:34 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2010-02-04 17:07 UTC (permalink / raw)
To: GDB
We shouldn't initialize readline if gdb_stdout isn't a tty. OK
to install?
Thanks.
H.J.
---
2010-02-04 H.J. Lu <hongjiu.lu@intel.com>
PR tui/9622
* tui/tui-interp.c (tui_init): Call tui_initialize_readline
only if gdb_stdout is a tty.
diff --git a/gdb/tui/tui-interp.c b/gdb/tui/tui-interp.c
index 3b59769..3bb8246 100644
--- a/gdb/tui/tui-interp.c
+++ b/gdb/tui/tui-interp.c
@@ -57,7 +57,8 @@ tui_init (int top_level)
tui_initialize_io ();
tui_initialize_win ();
- tui_initialize_readline ();
+ if (ui_file_isatty (gdb_stdout))
+ tui_initialize_readline ();
return NULL;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PATCH: PR tui/9622: tui over-eagerly initializes readline
2010-02-04 17:07 PATCH: PR tui/9622: tui over-eagerly initializes readline H.J. Lu
@ 2010-02-04 17:34 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2010-02-04 17:34 UTC (permalink / raw)
To: H.J. Lu; +Cc: GDB
>>>>> "HJ" == H J Lu <hongjiu.lu@intel.com> writes:
HJ> We shouldn't initialize readline if gdb_stdout isn't a tty. OK
HJ> to install?
I wrote a different patch a long time ago for this bug.
Mine checks if input is from a terminal...
I think yours is reasonable though. This is ok.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-04 17:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-04 17:07 PATCH: PR tui/9622: tui over-eagerly initializes readline H.J. Lu
2010-02-04 17:34 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox