From: Tom Tromey <tromey@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: PR tui/9622: tui over-eagerly initializes readline
Date: Thu, 04 Feb 2010 17:34:00 -0000 [thread overview]
Message-ID: <m3tytwkirc.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100204170700.GA12550@lucon.org> (H. J. Lu's message of "Thu, 4 Feb 2010 09:07:00 -0800")
>>>>> "HJ" == H J Lu <hongjiu.lu@intel.com> writes:
HJ> We shouldn't initialize readline if gdb_stdout isn't a tty. OK
HJ> to install?
I wrote a different patch a long time ago for this bug.
Mine checks if input is from a terminal...
I think yours is reasonable though. This is ok.
Tom
prev parent reply other threads:[~2010-02-04 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 17:07 H.J. Lu
2010-02-04 17:34 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3tytwkirc.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox