From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-69964-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13048 invoked by alias); 4 Feb 2010 17:34:09 -0000
Received: (qmail 13039 invoked by uid 22791); 4 Feb 2010 17:34:09 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Feb 2010 17:34:04 +0000
Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o14HY2A6027544 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Thu, 4 Feb 2010 12:34:02 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o14HY1uT022370; 	Thu, 4 Feb 2010 12:34:01 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o14HY0Mw001001; 	Thu, 4 Feb 2010 12:34:00 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id E37D137996D; Thu,  4 Feb 2010 10:33:59 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: PR tui/9622: tui over-eagerly initializes readline
References: <20100204170700.GA12550@lucon.org>
Reply-To: tromey@redhat.com
Date: Thu, 04 Feb 2010 17:34:00 -0000
In-Reply-To: <20100204170700.GA12550@lucon.org> (H. J. Lu's message of "Thu, 4 	Feb 2010 09:07:00 -0800")
Message-ID: <m3tytwkirc.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00123.txt.bz2

>>>>> "HJ" == H J Lu <hongjiu.lu@intel.com> writes:

HJ> We shouldn't initialize readline if gdb_stdout isn't a tty.  OK
HJ> to install?

I wrote a different patch a long time ago for this bug.
Mine checks if input is from a terminal...

I think yours is reasonable though.  This is ok.

Tom