From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3963 invoked by alias); 4 Feb 2010 17:07:06 -0000 Received: (qmail 3954 invoked by uid 22791); 4 Feb 2010 17:07:05 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_00,NO_DNS_FOR_FROM X-Spam-Check-By: sourceware.org Received: from mga06.intel.com (HELO orsmga101.jf.intel.com) (134.134.136.21) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Feb 2010 17:07:01 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 04 Feb 2010 09:05:33 -0800 X-ExtLoop1: 1 Received: from gnu-6.sc.intel.com ([10.3.194.107]) by orsmga001.jf.intel.com with ESMTP; 04 Feb 2010 09:06:51 -0800 Received: by gnu-6.sc.intel.com (Postfix, from userid 500) id 304CF812344; Thu, 4 Feb 2010 09:07:00 -0800 (PST) Date: Thu, 04 Feb 2010 17:07:00 -0000 From: "H.J. Lu" To: GDB Subject: PATCH: PR tui/9622: tui over-eagerly initializes readline Message-ID: <20100204170700.GA12550@lucon.org> Reply-To: "H.J. Lu" MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-08-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00120.txt.bz2 We shouldn't initialize readline if gdb_stdout isn't a tty. OK to install? Thanks. H.J. --- 2010-02-04 H.J. Lu PR tui/9622 * tui/tui-interp.c (tui_init): Call tui_initialize_readline only if gdb_stdout is a tty. diff --git a/gdb/tui/tui-interp.c b/gdb/tui/tui-interp.c index 3b59769..3bb8246 100644 --- a/gdb/tui/tui-interp.c +++ b/gdb/tui/tui-interp.c @@ -57,7 +57,8 @@ tui_init (int top_level) tui_initialize_io (); tui_initialize_win (); - tui_initialize_readline (); + if (ui_file_isatty (gdb_stdout)) + tui_initialize_readline (); return NULL; }