Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: gdb-patches@sourceware.org
Cc: brobecker@adacore.com (Joel Brobecker),
	        jan.kratochvil@redhat.com (Jan Kratochvil),
	        ratmice@gmail.com (Matt Rice)
Subject: [commit] Avoid Obj-C test timeouts due to symbols not found
Date: Tue, 29 Sep 2009 19:07:00 -0000	[thread overview]
Message-ID: <200909291907.n8TJ7g56007450@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <200909291645.n8TGjHHH031257@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at Sep 29, 2009 06:45:17 PM

I wrote:

> In this case, I agree that this change is much too risky for 7.0
> at this stage (even assuming Jan would manage to find and fix all
> ia64 regressions).  In any case, ObjC has always been broken on
> ppc64 so my patch isn't even a regression fix as such (reverting
> it will get us back to testsuite runs taking 20 mins longer than
> they should, but I guess I can live with that).
> 
> I'm going to revert my ObjC patch from the branch as soon as
> testing completes.  However, I'll leave it in mainline for now,
> to expose it to further testing and see what comes up.

I've reverted the patch on the branch now.

To alleviate the test case timeout problem, I've committed the
following test-suite only patch that converts the timeouts
into simple test case failures.  This makes the testsuite
usable again ...

Tested on ppc(64)-linux.  Committed to mainline and branch.

Bye,
Ulrich

ChangeLog:

	* gdb.objc/basicclass.exp: Disable pending breakpoint query.
	* gdb.objc/nondebug.exp: Likewise.

Index: gdb/testsuite/gdb.objc/basicclass.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.objc/basicclass.exp,v
retrieving revision 1.10
diff -c -p -r1.10 basicclass.exp
*** gdb/testsuite/gdb.objc/basicclass.exp	3 Jan 2009 05:58:06 -0000	1.10
--- gdb/testsuite/gdb.objc/basicclass.exp	29 Sep 2009 18:24:15 -0000
*************** do_objc_tests
*** 102,107 ****
--- 102,112 ----
  #
  # Breakpoint tests
  #
+ 
+ # Disable pending breakpoint query to avoid timeouts
+ # if Obj-C symbols cannot be found
+ gdb_test "set breakpoint pending off" "" "set breakpoint pending"
+ 
  gdb_test "break doIt" \
      "Breakpoint.*at.* file .*$srcfile, line.29.*" \
      "breakpoint method"
Index: gdb/testsuite/gdb.objc/nondebug.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.objc/nondebug.exp,v
retrieving revision 1.6
diff -c -p -r1.6 nondebug.exp
*** gdb/testsuite/gdb.objc/nondebug.exp	3 Jan 2009 05:58:06 -0000	1.6
--- gdb/testsuite/gdb.objc/nondebug.exp	29 Sep 2009 18:24:15 -0000
*************** proc do_objc_tests {} {
*** 56,61 ****
--- 56,65 ----
  
  do_objc_tests
  
+ # Disable pending breakpoint query to avoid timeouts
+ # if Obj-C symbols cannot be found
+ gdb_test "set breakpoint pending off" "" "set breakpoint pending"
+ 
  #
  # Break on multiply defined non-debuggable symbol (PR objc/1236)
  #


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2009-09-29 19:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-27 21:49 [rfc] Fix Obj-C method calls on 64-bit PowerPC Ulrich Weigand
2009-09-28 17:51 ` Joel Brobecker
2009-09-28 22:41   ` Matt Rice
2009-09-29  0:50     ` Ulrich Weigand
2009-09-29 15:44       ` [ia64] Regression: " Jan Kratochvil
2009-09-29 16:07         ` Ulrich Weigand
2009-09-29 16:17           ` Jan Kratochvil
2009-09-29 16:16         ` Joel Brobecker
2009-09-29 16:30           ` Jan Kratochvil
2009-09-29 16:40             ` Joel Brobecker
2009-09-29 19:11               ` Jan Kratochvil
2009-09-29 16:45           ` Ulrich Weigand
2009-09-29 19:07             ` Ulrich Weigand [this message]
2009-09-29 17:27         ` [rfc] Move PC in-range check in objc-lang.c:find_methods (Re: [ia64] Regression) Ulrich Weigand
2009-09-29 17:46           ` Joel Brobecker
2009-09-29 21:08         ` [ia64] Regression: Re: [rfc] Fix Obj-C method calls on 64-bit PowerPC Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909291907.n8TJ7g56007450@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=ratmice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox