From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30180 invoked by alias); 29 Sep 2009 19:07:53 -0000 Received: (qmail 30169 invoked by uid 22791); 29 Sep 2009 19:07:52 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.17.164) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Sep 2009 19:07:47 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.1/8.13.1) with ESMTP id n8TJ7iIf010128 for ; Tue, 29 Sep 2009 19:07:44 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n8TJ7iUc3424422 for ; Tue, 29 Sep 2009 21:07:44 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n8TJ7ihr007455 for ; Tue, 29 Sep 2009 21:07:44 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n8TJ7g56007450; Tue, 29 Sep 2009 21:07:42 +0200 Message-Id: <200909291907.n8TJ7g56007450@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 29 Sep 2009 21:07:42 +0200 Subject: [commit] Avoid Obj-C test timeouts due to symbols not found To: gdb-patches@sourceware.org Date: Tue, 29 Sep 2009 19:07:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com (Joel Brobecker), jan.kratochvil@redhat.com (Jan Kratochvil), ratmice@gmail.com (Matt Rice) In-Reply-To: <200909291645.n8TGjHHH031257@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at Sep 29, 2009 06:45:17 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00931.txt.bz2 I wrote: > In this case, I agree that this change is much too risky for 7.0 > at this stage (even assuming Jan would manage to find and fix all > ia64 regressions). In any case, ObjC has always been broken on > ppc64 so my patch isn't even a regression fix as such (reverting > it will get us back to testsuite runs taking 20 mins longer than > they should, but I guess I can live with that). > > I'm going to revert my ObjC patch from the branch as soon as > testing completes. However, I'll leave it in mainline for now, > to expose it to further testing and see what comes up. I've reverted the patch on the branch now. To alleviate the test case timeout problem, I've committed the following test-suite only patch that converts the timeouts into simple test case failures. This makes the testsuite usable again ... Tested on ppc(64)-linux. Committed to mainline and branch. Bye, Ulrich ChangeLog: * gdb.objc/basicclass.exp: Disable pending breakpoint query. * gdb.objc/nondebug.exp: Likewise. Index: gdb/testsuite/gdb.objc/basicclass.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.objc/basicclass.exp,v retrieving revision 1.10 diff -c -p -r1.10 basicclass.exp *** gdb/testsuite/gdb.objc/basicclass.exp 3 Jan 2009 05:58:06 -0000 1.10 --- gdb/testsuite/gdb.objc/basicclass.exp 29 Sep 2009 18:24:15 -0000 *************** do_objc_tests *** 102,107 **** --- 102,112 ---- # # Breakpoint tests # + + # Disable pending breakpoint query to avoid timeouts + # if Obj-C symbols cannot be found + gdb_test "set breakpoint pending off" "" "set breakpoint pending" + gdb_test "break doIt" \ "Breakpoint.*at.* file .*$srcfile, line.29.*" \ "breakpoint method" Index: gdb/testsuite/gdb.objc/nondebug.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.objc/nondebug.exp,v retrieving revision 1.6 diff -c -p -r1.6 nondebug.exp *** gdb/testsuite/gdb.objc/nondebug.exp 3 Jan 2009 05:58:06 -0000 1.6 --- gdb/testsuite/gdb.objc/nondebug.exp 29 Sep 2009 18:24:15 -0000 *************** proc do_objc_tests {} { *** 56,61 **** --- 56,65 ---- do_objc_tests + # Disable pending breakpoint query to avoid timeouts + # if Obj-C symbols cannot be found + gdb_test "set breakpoint pending off" "" "set breakpoint pending" + # # Break on multiply defined non-debuggable symbol (PR objc/1236) # -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com