Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Ulrich Weigand <uweigand@de.ibm.com>,
	Matt Rice <ratmice@gmail.com>,
		gdb-patches@sourceware.org
Subject: Re: [ia64] Regression: Re: [rfc] Fix Obj-C method calls on 64-bit 	PowerPC
Date: Tue, 29 Sep 2009 16:16:00 -0000	[thread overview]
Message-ID: <20090929161608.GN9003@adacore.com> (raw)
In-Reply-To: <20090929154328.GA15183@host0.dyn.jankratochvil.net>

> ia64 is now broken, also on the 7.0 branch due to the check-in:
>  http://sourceware.org/ml/gdb-cvs/2009-09/msg00210.html

Darn function descriptors on ia64, and darn objc support that
overmatches. One of the assumptions I was making when considering
this patch for 7.0 was the fact that it would only affect ObjC.
But I should have known better after all the discussions I had
with Matt Rice. My suggestion is to revert it from 7.0, and maybe
consider it for 7.0.1 if we manage to fix all unexpected side-effects
by then.

> 2009-09-29  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* ia64-tdep.c (ia64_convert_from_func_ptr_addr): New variable buf.
> 	Check first the descriptor memory is readable.

This patch is OK.

-- 
Joel


  parent reply	other threads:[~2009-09-29 16:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-27 21:49 Ulrich Weigand
2009-09-28 17:51 ` Joel Brobecker
2009-09-28 22:41   ` Matt Rice
2009-09-29  0:50     ` Ulrich Weigand
2009-09-29 15:44       ` [ia64] Regression: " Jan Kratochvil
2009-09-29 16:07         ` Ulrich Weigand
2009-09-29 16:17           ` Jan Kratochvil
2009-09-29 16:16         ` Joel Brobecker [this message]
2009-09-29 16:30           ` Jan Kratochvil
2009-09-29 16:40             ` Joel Brobecker
2009-09-29 19:11               ` Jan Kratochvil
2009-09-29 16:45           ` Ulrich Weigand
2009-09-29 19:07             ` [commit] Avoid Obj-C test timeouts due to symbols not found Ulrich Weigand
2009-09-29 17:27         ` [rfc] Move PC in-range check in objc-lang.c:find_methods (Re: [ia64] Regression) Ulrich Weigand
2009-09-29 17:46           ` Joel Brobecker
2009-09-29 21:08         ` [ia64] Regression: Re: [rfc] Fix Obj-C method calls on 64-bit PowerPC Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090929161608.GN9003@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=ratmice@gmail.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox