From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5511 invoked by alias); 29 Sep 2009 16:16:26 -0000 Received: (qmail 5498 invoked by uid 22791); 29 Sep 2009 16:16:25 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Sep 2009 16:16:17 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BE6D92BAB85; Tue, 29 Sep 2009 12:16:15 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FJ1mib08Itxz; Tue, 29 Sep 2009 12:16:15 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6ACC02BAB64; Tue, 29 Sep 2009 12:16:15 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 79055F593D; Tue, 29 Sep 2009 09:16:08 -0700 (PDT) Date: Tue, 29 Sep 2009 16:16:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Ulrich Weigand , Matt Rice , gdb-patches@sourceware.org Subject: Re: [ia64] Regression: Re: [rfc] Fix Obj-C method calls on 64-bit PowerPC Message-ID: <20090929161608.GN9003@adacore.com> References: <8ba6bed40909281541y1d9455fas873a602caf2508fa@mail.gmail.com> <200909290050.n8T0o1dF004541@d12av02.megacenter.de.ibm.com> <20090929154328.GA15183@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090929154328.GA15183@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00921.txt.bz2 > ia64 is now broken, also on the 7.0 branch due to the check-in: > http://sourceware.org/ml/gdb-cvs/2009-09/msg00210.html Darn function descriptors on ia64, and darn objc support that overmatches. One of the assumptions I was making when considering this patch for 7.0 was the fact that it would only affect ObjC. But I should have known better after all the discussions I had with Matt Rice. My suggestion is to revert it from 7.0, and maybe consider it for 7.0.1 if we manage to fix all unexpected side-effects by then. > 2009-09-29 Jan Kratochvil > > * ia64-tdep.c (ia64_convert_from_func_ptr_addr): New variable buf. > Check first the descriptor memory is readable. This patch is OK. -- Joel