From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: brobecker@adacore.com (Joel Brobecker)
Cc: jan.kratochvil@redhat.com (Jan Kratochvil),
ratmice@gmail.com (Matt Rice),
gdb-patches@sourceware.org
Subject: Re: [ia64] Regression: Re: [rfc] Fix Obj-C method calls on 64-bit PowerPC
Date: Tue, 29 Sep 2009 16:45:00 -0000 [thread overview]
Message-ID: <200909291645.n8TGjHHH031257@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20090929161608.GN9003@adacore.com> from "Joel Brobecker" at Sep 29, 2009 09:16:08 AM
Joel Brobecker wrote:
> > ia64 is now broken, also on the 7.0 branch due to the check-in:
> > http://sourceware.org/ml/gdb-cvs/2009-09/msg00210.html
>
> Darn function descriptors on ia64, and darn objc support that
> overmatches. One of the assumptions I was making when considering
> this patch for 7.0 was the fact that it would only affect ObjC.
> But I should have known better after all the discussions I had
> with Matt Rice. My suggestion is to revert it from 7.0, and maybe
> consider it for 7.0.1 if we manage to fix all unexpected side-effects
> by then.
Argh. I (perhaps naively) assumed that the "decode_objc" routine
would only trigger for ObjC source files ... Of course this turns
out not to be true, and it is in fact invoked for *any* symbol
lookup first, just to find out that the symbol is not ObjC.
In this case, I agree that this change is much too risky for 7.0
at this stage (even assuming Jan would manage to find and fix all
ia64 regressions). In any case, ObjC has always been broken on
ppc64 so my patch isn't even a regression fix as such (reverting
it will get us back to testsuite runs taking 20 mins longer than
they should, but I guess I can live with that).
I'm going to revert my ObjC patch from the branch as soon as
testing completes. However, I'll leave it in mainline for now,
to expose it to further testing and see what comes up.
If there is a follow-on release on the 7.0 branch (but I do not
consider the ppc64 ObjC issue by itself sufficient cause to
trigger such a release -- only if we decide to do it anyway),
and the patch has been on mainline for a while with the
resulting issues fixed, we can revisit the decision to put
it on the branch.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2009-09-29 16:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-27 21:49 Ulrich Weigand
2009-09-28 17:51 ` Joel Brobecker
2009-09-28 22:41 ` Matt Rice
2009-09-29 0:50 ` Ulrich Weigand
2009-09-29 15:44 ` [ia64] Regression: " Jan Kratochvil
2009-09-29 16:07 ` Ulrich Weigand
2009-09-29 16:17 ` Jan Kratochvil
2009-09-29 16:16 ` Joel Brobecker
2009-09-29 16:30 ` Jan Kratochvil
2009-09-29 16:40 ` Joel Brobecker
2009-09-29 19:11 ` Jan Kratochvil
2009-09-29 16:45 ` Ulrich Weigand [this message]
2009-09-29 19:07 ` [commit] Avoid Obj-C test timeouts due to symbols not found Ulrich Weigand
2009-09-29 17:27 ` [rfc] Move PC in-range check in objc-lang.c:find_methods (Re: [ia64] Regression) Ulrich Weigand
2009-09-29 17:46 ` Joel Brobecker
2009-09-29 21:08 ` [ia64] Regression: Re: [rfc] Fix Obj-C method calls on 64-bit PowerPC Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909291645.n8TGjHHH031257@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=ratmice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox