From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29476 invoked by alias); 29 Sep 2009 16:45:32 -0000 Received: (qmail 29338 invoked by uid 22791); 29 Sep 2009 16:45:29 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.17.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Sep 2009 16:45:22 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.1/8.13.1) with ESMTP id n8TGjJ0J005796 for ; Tue, 29 Sep 2009 16:45:19 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n8TGjJGD3363040 for ; Tue, 29 Sep 2009 18:45:19 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n8TGjIr2031268 for ; Tue, 29 Sep 2009 18:45:19 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n8TGjHHH031257; Tue, 29 Sep 2009 18:45:17 +0200 Message-Id: <200909291645.n8TGjHHH031257@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 29 Sep 2009 18:45:17 +0200 Subject: Re: [ia64] Regression: Re: [rfc] Fix Obj-C method calls on 64-bit PowerPC To: brobecker@adacore.com (Joel Brobecker) Date: Tue, 29 Sep 2009 16:45:00 -0000 From: "Ulrich Weigand" Cc: jan.kratochvil@redhat.com (Jan Kratochvil), ratmice@gmail.com (Matt Rice), gdb-patches@sourceware.org In-Reply-To: <20090929161608.GN9003@adacore.com> from "Joel Brobecker" at Sep 29, 2009 09:16:08 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00926.txt.bz2 Joel Brobecker wrote: > > ia64 is now broken, also on the 7.0 branch due to the check-in: > > http://sourceware.org/ml/gdb-cvs/2009-09/msg00210.html > > Darn function descriptors on ia64, and darn objc support that > overmatches. One of the assumptions I was making when considering > this patch for 7.0 was the fact that it would only affect ObjC. > But I should have known better after all the discussions I had > with Matt Rice. My suggestion is to revert it from 7.0, and maybe > consider it for 7.0.1 if we manage to fix all unexpected side-effects > by then. Argh. I (perhaps naively) assumed that the "decode_objc" routine would only trigger for ObjC source files ... Of course this turns out not to be true, and it is in fact invoked for *any* symbol lookup first, just to find out that the symbol is not ObjC. In this case, I agree that this change is much too risky for 7.0 at this stage (even assuming Jan would manage to find and fix all ia64 regressions). In any case, ObjC has always been broken on ppc64 so my patch isn't even a regression fix as such (reverting it will get us back to testsuite runs taking 20 mins longer than they should, but I guess I can live with that). I'm going to revert my ObjC patch from the branch as soon as testing completes. However, I'll leave it in mainline for now, to expose it to further testing and see what comes up. If there is a follow-on release on the 7.0 branch (but I do not consider the ppc64 ObjC issue by itself sufficient cause to trigger such a release -- only if we decide to do it anyway), and the patch has been on mainline for a while with the resulting issues fixed, we can revisit the decision to put it on the branch. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com