From: Joel Brobecker <brobecker@adacore.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Fix Obj-C method calls on 64-bit PowerPC
Date: Mon, 28 Sep 2009 17:51:00 -0000 [thread overview]
Message-ID: <20090928163248.GF9003@adacore.com> (raw)
In-Reply-To: <200909272149.n8RLnRxc032281@d12av02.megacenter.de.ibm.com>
> * eval.c (evaluate_subexp_standard) [OP_OBJC_MSGCALL]: Support
> platforms that use function descriptors. Prefer to use function
> pointer types instead of function types.
> * linespec.c (decode_objc): Support function descriptors. Fully
> initialize SAL result.
> * objc-lang.c (find_methods): Support function descriptors.
> Do not require function symbol to point to text section.
>
> * ppc-sysv-tdep.c (ppc64_sysv_abi_push_dummy_call): When calling
> via a function pointer, use the descriptor it point to.
^^^^^ points ;-)
Seems fine to me. Given that this fixes SEGVs, we should consider it
for inclusion in the 7.0 branch. You might want to ask ratmice@gmail.com
to give it a test before installing on 7.0, but I don't think it would
buy us much given that you already tested on s390. At least the risk
is limited to ObjC.
--
Joel
next prev parent reply other threads:[~2009-09-28 17:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-27 21:49 Ulrich Weigand
2009-09-28 17:51 ` Joel Brobecker [this message]
2009-09-28 22:41 ` Matt Rice
2009-09-29 0:50 ` Ulrich Weigand
2009-09-29 15:44 ` [ia64] Regression: " Jan Kratochvil
2009-09-29 16:07 ` Ulrich Weigand
2009-09-29 16:17 ` Jan Kratochvil
2009-09-29 16:16 ` Joel Brobecker
2009-09-29 16:30 ` Jan Kratochvil
2009-09-29 16:40 ` Joel Brobecker
2009-09-29 19:11 ` Jan Kratochvil
2009-09-29 16:45 ` Ulrich Weigand
2009-09-29 19:07 ` [commit] Avoid Obj-C test timeouts due to symbols not found Ulrich Weigand
2009-09-29 17:27 ` [rfc] Move PC in-range check in objc-lang.c:find_methods (Re: [ia64] Regression) Ulrich Weigand
2009-09-29 17:46 ` Joel Brobecker
2009-09-29 21:08 ` [ia64] Regression: Re: [rfc] Fix Obj-C method calls on 64-bit PowerPC Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090928163248.GF9003@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox