From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29181 invoked by alias); 28 Sep 2009 17:51:21 -0000 Received: (qmail 29166 invoked by uid 22791); 28 Sep 2009 17:51:20 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Sep 2009 17:51:16 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EC7FC2BAAC3; Mon, 28 Sep 2009 13:51:14 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mnedqKQ7n8Yh; Mon, 28 Sep 2009 13:51:14 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B6F682BAB34; Mon, 28 Sep 2009 13:51:14 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 483F8F594C; Mon, 28 Sep 2009 09:32:48 -0700 (PDT) Date: Mon, 28 Sep 2009 17:51:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfc] Fix Obj-C method calls on 64-bit PowerPC Message-ID: <20090928163248.GF9003@adacore.com> References: <200909272149.n8RLnRxc032281@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200909272149.n8RLnRxc032281@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00875.txt.bz2 > * eval.c (evaluate_subexp_standard) [OP_OBJC_MSGCALL]: Support > platforms that use function descriptors. Prefer to use function > pointer types instead of function types. > * linespec.c (decode_objc): Support function descriptors. Fully > initialize SAL result. > * objc-lang.c (find_methods): Support function descriptors. > Do not require function symbol to point to text section. > > * ppc-sysv-tdep.c (ppc64_sysv_abi_push_dummy_call): When calling > via a function pointer, use the descriptor it point to. ^^^^^ points ;-) Seems fine to me. Given that this fixes SEGVs, we should consider it for inclusion in the 7.0 branch. You might want to ask ratmice@gmail.com to give it a test before installing on 7.0, but I don't think it would buy us much given that you already tested on s390. At least the risk is limited to ObjC. -- Joel