[RFA] trailing backslash in top-level Makefile

[RFA] trailing backslash in top-level Makefile

[Jerome Guitton]

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]


The top-level Makefile.in may generate a trailing backslash at the end
of the target "all" (if gcc-bootstrap is false). Something like that:

[...]
all:
        @: $(MAKE); $(unstage)
        @r=`${PWD_COMMAND}`; export r; \
        s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
          $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target \

.PHONY: all-build
[...]


On most system, that's fine. However, this is rejected by some shells.
For example, the system bash on some solaris systems:

ostende% bash --version 
GNU bash, version 2.03.0(1)-release (sparc-sun-solaris)
Copyright 1998 Free Software Foundation, Inc.
> bash -c "ls \\"

bash: -c: line 2: syntax error: unexpected end of file

The patch in attachment would fix the problem. It's a little bit ugly
though. "echo" is used as a "nop". Would someone have a better idea to fix
the problem?


2009-06-02  Jerome Guitton  <guitton@adacore.com>

	* Makefile.tpl: Remove a trailing backslash.
	* Makefile.in: Regenerate.


[-- Attachment #2: toplevel.diff --]
[-- Type: text/x-diff, Size: 1200 bytes --]

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/Makefile.in,v
retrieving revision 1.302
diff -u -r1.302 Makefile.in
--- Makefile.in	2 Jun 2009 08:23:45 -0000	1.302
+++ Makefile.in	2 Jun 2009 15:18:31 -0000
@@ -859,11 +859,11 @@
 	  $(MAKE) $(TARGET_FLAGS_TO_PASS) all-host all-target; \
 	else \
 @endif gcc-bootstrap
-	  $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target \
+	  $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target ; \
 @if gcc-bootstrap
-	    ; \
 	fi
 @endif gcc-bootstrap
+	echo
 
 .PHONY: all-build
 
Index: Makefile.tpl
===================================================================
RCS file: /cvs/src/src/Makefile.tpl,v
retrieving revision 1.206
diff -u -r1.206 Makefile.tpl
--- Makefile.tpl	2 Jun 2009 08:23:45 -0000	1.206
+++ Makefile.tpl	2 Jun 2009 15:18:38 -0000
@@ -625,11 +625,11 @@
 	  $(MAKE) $(TARGET_FLAGS_TO_PASS) all-host all-target; \
 	else \
 @endif gcc-bootstrap
-	  $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target \
+	  $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target ; \
 @if gcc-bootstrap
-	    ; \
 	fi
 @endif gcc-bootstrap
+	echo
 
 .PHONY: all-build
 [+ FOR build_modules +]

Re: [RFA] trailing backslash in top-level Makefile

[Ralf Wildenhues]

Hello Jerome,

* Jerome Guitton wrote on Tue, Jun 02, 2009 at 06:33:56PM CEST:
> 
> The top-level Makefile.in may generate a trailing backslash at the end
> of the target "all" (if gcc-bootstrap is false). Something like that:

>         @: $(MAKE); $(unstage)
>         @r=`${PWD_COMMAND}`; export r; \
>         s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
>           $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target \

> On most system, that's fine. However, this is rejected by some shells.
> For example, the system bash on some solaris systems:
> 
> ostende% bash --version 
> GNU bash, version 2.03.0(1)-release (sparc-sun-solaris)
> Copyright 1998 Free Software Foundation, Inc.
> > bash -c "ls \\"
> 
> bash: -c: line 2: syntax error: unexpected end of file

Thank you!  I couldn't find this bit of information when last looking
for it; will update the Autoconf manual section about make/shell
portability issues with this.

> The patch in attachment would fix the problem. It's a little bit ugly
> though. "echo" is used as a "nop". Would someone have a better idea to fix
> the problem?

The fix is wrong as it disables transporting a nonzero exit status from
the $(MAKE) command back to the toplevel make.

I suggest this still-untested patch (gimme a couple of hours).

Thanks,
Ralf

	* Makefile.tpl: Avoid a trailing backslash.
	* Makefile.in: Regenerate.

diff --git a/Makefile.tpl b/Makefile.tpl
index f49f3fc..db10e71 100644
--- a/Makefile.tpl
+++ b/Makefile.tpl
@@ -628,8 +628,9 @@ all:
 	  $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target \
 @if gcc-bootstrap
 	    ; \
-	fi
+	fi \
 @endif gcc-bootstrap
+	&& :
 
 .PHONY: all-build
 [+ FOR build_modules +]

Re: [RFA] trailing backslash in top-level Makefile

[Ralf Wildenhues]

* Ralf Wildenhues wrote on Tue, Jun 02, 2009 at 08:00:21PM CEST:
> 	* Makefile.tpl: Avoid a trailing backslash.
> 	* Makefile.in: Regenerate.

> --- a/Makefile.tpl
> +++ b/Makefile.tpl
> @@ -628,8 +628,9 @@ all:
>  	  $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target \
>  @if gcc-bootstrap
>  	    ; \
> -	fi
> +	fi \
>  @endif gcc-bootstrap
> +	&& :
>  
>  .PHONY: all-build
>  [+ FOR build_modules +]

This patch seems to fix the issue, and as such: OK to apply to GCC and
src?

All my testing has been casual rather than following the rules, but I
think I've tried out all failure cases in GCC and src.  Bummer there is
no exact opposite of the '@if gcc-bootstrap' switch yet (neither it nor
gcc-no-bootstrap are true for a binutils-only build), it would make for
a more readable rule.  Hmm, maybe we should add one later.

Cheers,
Ralf

Re: [RFA] trailing backslash in top-level Makefile

[DJ Delorie]

> > --- a/Makefile.tpl
> > +++ b/Makefile.tpl
> > @@ -628,8 +628,9 @@ all:
> >  	  $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target \
> >  @if gcc-bootstrap
> >  	    ; \
> > -	fi
> > +	fi \
> >  @endif gcc-bootstrap
> > +	&& :
> >  
> >  .PHONY: all-build
> >  [+ FOR build_modules +]
> 
> This patch seems to fix the issue, and as such: OK to apply to GCC and
> src?

I'm OK with it.

Re: [RFA] trailing backslash in top-level Makefile

[Ralf Wildenhues]

* DJ Delorie wrote on Wed, Jun 03, 2009 at 12:07:47AM CEST:
> > This patch seems to fix the issue, and as such: OK to apply to GCC and
> > src?
> 
> I'm OK with it.

* Alexandre Oliva wrote on Wed, Jun 03, 2009 at 01:15:53AM CEST:
> This is ok, thanks.

Pushed, thanks!

Re: [RFA] trailing backslash in top-level Makefile

[Alexandre Oliva]

On Jun  2, 2009, Ralf Wildenhues <Ralf.Wildenhues@gmx.de> wrote:

>> $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target \

Oh, my, so many tries to fix this one small problem :-(  Sorry that I
introduced it and failed to fix it so far.

> 	* Makefile.tpl: Avoid a trailing backslash.
> 	* Makefile.in: Regenerate.

This is ok, thanks.

-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist      Red Hat Brazil Compiler Engineer

Re: [RFA] trailing backslash in top-level Makefile

[Jerome Guitton]

Ralf Wildenhues (Ralf.Wildenhues@gmx.de):

> I suggest this still-untested patch (gimme a couple of hours).

I confirm that your patch fixes the problem on my side; thanks!