From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1821 invoked by alias); 2 Jun 2009 22:04:26 -0000 Received: (qmail 1593 invoked by uid 22791); 2 Jun 2009 22:04:24 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.gmx.net (HELO mail.gmx.net) (213.165.64.20) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Tue, 02 Jun 2009 22:04:15 +0000 Received: (qmail invoked by alias); 02 Jun 2009 22:04:11 -0000 Received: from xdsl-87-78-111-227.netcologne.de (EHLO localhost.localdomain) [87.78.111.227] by mail.gmx.net (mp007) with SMTP; 03 Jun 2009 00:04:11 +0200 Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1MBc5W-0005O1-3v; Wed, 03 Jun 2009 00:04:06 +0200 Date: Tue, 02 Jun 2009 22:04:00 -0000 From: Ralf Wildenhues To: Jerome Guitton , gdb-patches@sourceware.org, gcc-patches@gcc.gnu.org, binutils@sourceware.org Subject: Re: [RFA] trailing backslash in top-level Makefile Message-ID: <20090602220405.GA13584@gmx.de> Mail-Followup-To: Ralf Wildenhues , Jerome Guitton , gdb-patches@sourceware.org, gcc-patches@gcc.gnu.org, binutils@sourceware.org References: <20090602163356.GB20678@adacore.com> <20090602180020.GA3739@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090602180020.GA3739@gmx.de> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00024.txt.bz2 * Ralf Wildenhues wrote on Tue, Jun 02, 2009 at 08:00:21PM CEST: > * Makefile.tpl: Avoid a trailing backslash. > * Makefile.in: Regenerate. > --- a/Makefile.tpl > +++ b/Makefile.tpl > @@ -628,8 +628,9 @@ all: > $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target \ > @if gcc-bootstrap > ; \ > - fi > + fi \ > @endif gcc-bootstrap > + && : > > .PHONY: all-build > [+ FOR build_modules +] This patch seems to fix the issue, and as such: OK to apply to GCC and src? All my testing has been casual rather than following the rules, but I think I've tried out all failure cases in GCC and src. Bummer there is no exact opposite of the '@if gcc-bootstrap' switch yet (neither it nor gcc-no-bootstrap are true for a binutils-only build), it would make for a more readable rule. Hmm, maybe we should add one later. Cheers, Ralf