From: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
To: Jerome Guitton <guitton@adacore.com>,
gdb-patches@sourceware.org, gcc-patches@gcc.gnu.org,
binutils@sourceware.org
Subject: Re: [RFA] trailing backslash in top-level Makefile
Date: Tue, 02 Jun 2009 22:04:00 -0000 [thread overview]
Message-ID: <20090602220405.GA13584@gmx.de> (raw)
In-Reply-To: <20090602180020.GA3739@gmx.de>
* Ralf Wildenhues wrote on Tue, Jun 02, 2009 at 08:00:21PM CEST:
> * Makefile.tpl: Avoid a trailing backslash.
> * Makefile.in: Regenerate.
> --- a/Makefile.tpl
> +++ b/Makefile.tpl
> @@ -628,8 +628,9 @@ all:
> $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target \
> @if gcc-bootstrap
> ; \
> - fi
> + fi \
> @endif gcc-bootstrap
> + && :
>
> .PHONY: all-build
> [+ FOR build_modules +]
This patch seems to fix the issue, and as such: OK to apply to GCC and
src?
All my testing has been casual rather than following the rules, but I
think I've tried out all failure cases in GCC and src. Bummer there is
no exact opposite of the '@if gcc-bootstrap' switch yet (neither it nor
gcc-no-bootstrap are true for a binutils-only build), it would make for
a more readable rule. Hmm, maybe we should add one later.
Cheers,
Ralf
next prev parent reply other threads:[~2009-06-02 22:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 16:34 Jerome Guitton
2009-06-02 18:00 ` Ralf Wildenhues
2009-06-02 22:04 ` Ralf Wildenhues [this message]
2009-06-02 22:08 ` DJ Delorie
2009-06-03 6:16 ` Ralf Wildenhues
2009-06-02 23:16 ` Alexandre Oliva
2009-06-03 8:44 ` Jerome Guitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090602220405.GA13584@gmx.de \
--to=ralf.wildenhues@gmx.de \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=guitton@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox