From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org,
Jan Kratochvil <jan.kratochvil@redhat.com>,
Eli Zaretskii <eliz@gnu.org>,
tromey@redhat.com, mark.kettenis@xs4all.nl, drow@false.org
Subject: Re: [patch] Fix `return' of long/long-long results with no debuginfo
Date: Wed, 18 Mar 2009 14:44:00 -0000 [thread overview]
Message-ID: <20090318135448.GA18396@adacore.com> (raw)
In-Reply-To: <200903180420.37390.pedro@codesourcery.com>
> The issue is that it relies on parsing the output of printf, which
> doesn't work against remote targets that don't implement some kind
> of semi-hosting io, like gdbserver.
Yeah - the worse part is that I saw the use of printf, frowned on it,
but let it go because I didn't see a quick way of avoiding it. Lessons
learned for me.
> 2009-03-18 Pedro Alves <pedro@codesourcery.com>
>
> * return-nodebug.c: Don't include stdio.h.
> (init): Delete.
> (func): Delete definition and provide extern declaration.
> (t): New.
> (main): Don't call printf. Call func and store its result in t.
> * return-nodebug1.c: New.
> * return-nodebug.exp: Don't expect stdio output. Instead, print
> the global variable t. Drop printf formatters and cast types from
> foreach loop. Don't use prepare_for_testing. Compile
> return-nodebug.c and return-nodebug1.c in separate steps. Don't
> define FORMAT or CAST.
Looks great to me.
In the future, don't feel obliged to fix it yourself unless you want to.
I can help fix my own messes...
--
Joel
next prev parent reply other threads:[~2009-03-18 13:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 19:45 Jan Kratochvil
2009-02-11 20:40 ` Mark Kettenis
2009-02-11 20:50 ` Daniel Jacobowitz
2009-02-11 21:23 ` Mark Kettenis
2009-02-11 21:47 ` Jan Kratochvil
2009-02-11 21:58 ` Mark Kettenis
2009-02-11 22:08 ` Jan Kratochvil
2009-02-11 22:38 ` Mark Kettenis
2009-02-11 22:50 ` Jan Kratochvil
2009-03-03 18:10 ` Tom Tromey
2009-03-04 21:29 ` Mark Kettenis
2009-03-05 0:15 ` Tom Tromey
2009-03-09 1:55 ` Jan Kratochvil
2009-03-09 22:38 ` Mark Kettenis
2009-03-11 16:49 ` Joel Brobecker
2009-03-11 20:23 ` Tom Tromey
2009-03-11 21:48 ` Joel Brobecker
2009-03-13 19:50 ` Jan Kratochvil
2009-03-13 23:00 ` Joel Brobecker
2009-03-14 10:45 ` Eli Zaretskii
2009-03-14 22:09 ` Jan Kratochvil
2009-03-14 22:18 ` Eli Zaretskii
2009-03-15 9:22 ` Joel Brobecker
2009-03-15 18:15 ` Jan Kratochvil
2009-03-18 4:36 ` Pedro Alves
2009-03-18 14:44 ` Joel Brobecker [this message]
2009-03-18 15:39 ` Jan Kratochvil
2009-03-18 15:46 ` Pedro Alves
2009-02-11 22:44 ` Mark Kettenis
2009-02-12 9:41 ` Jan Kratochvil
2009-02-12 14:36 ` Pierre Muller
2009-02-12 14:44 ` Jan Kratochvil
2009-02-14 21:59 ` Mark Kettenis
2009-02-21 12:47 ` Jan Kratochvil
2009-02-21 13:44 ` Mark Kettenis
2009-02-21 15:58 ` Jan Kratochvil
2009-02-21 16:21 ` Mark Kettenis
2009-02-21 16:32 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090318135448.GA18396@adacore.com \
--to=brobecker@adacore.com \
--cc=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=mark.kettenis@xs4all.nl \
--cc=pedro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox