Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jan.kratochvil@redhat.com
Cc: drow@false.org, gdb-patches@sourceware.org
Subject: Re: [patch] Fix `return' of long/long-long results with no 	debuginfo
Date: Wed, 11 Feb 2009 22:44:00 -0000	[thread overview]
Message-ID: <200902112244.n1BMiK36012947@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20090211214646.GA22247@host0.dyn.jankratochvil.net> (message 	from Jan Kratochvil on Wed, 11 Feb 2009 22:46:47 +0100)

> Date: Wed, 11 Feb 2009 22:46:47 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> > From: Daniel Jacobowitz <drow@false.org>
> > > Everything we pick will be wrong some of the time, but IMO "long" is
> > > maximally useful.  "long long" on 32-bit platforms is going to pick
> > > up garbage from the next register for int or void * returns.
> 
> Garbage would be seen by caller of a `long long' returning callee where GDB
> would return something smaller (like `int').  As GDB writes (not "reads") the
> register it just will write zero to one excessive but unused register.  This
> register must be callee-saved (not caller-saved) by the ABI supporting `long
> long' return type and GDB already asserts the return type is
> RETURN_VALUE_REGISTER_CONVENTION.

Thinking a bit more of this now, things all depend on the calling
convention.  I'm not convinced casting to `long long' is safe in all
cases, especially on 32-bit big-endian machines.  It really might do
the wrong thing there, exposing garbage or the wrong 32 bits of the
64-bit value.

The 'int' case is really special in a sense, very much because of the
K&R heritage.  It has to work for all types that are sizeof(int) or
smaller.


  parent reply	other threads:[~2009-02-11 22:44 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 19:45 Jan Kratochvil
2009-02-11 20:40 ` Mark Kettenis
2009-02-11 20:50   ` Daniel Jacobowitz
2009-02-11 21:23     ` Mark Kettenis
2009-02-11 21:47       ` Jan Kratochvil
2009-02-11 21:58         ` Mark Kettenis
2009-02-11 22:08           ` Jan Kratochvil
2009-02-11 22:38             ` Mark Kettenis
2009-02-11 22:50               ` Jan Kratochvil
2009-03-03 18:10                 ` Tom Tromey
2009-03-04 21:29                   ` Mark Kettenis
2009-03-05  0:15                     ` Tom Tromey
2009-03-09  1:55                       ` Jan Kratochvil
2009-03-09 22:38                         ` Mark Kettenis
2009-03-11 16:49                           ` Joel Brobecker
2009-03-11 20:23                             ` Tom Tromey
2009-03-11 21:48                               ` Joel Brobecker
2009-03-13 19:50                                 ` Jan Kratochvil
2009-03-13 23:00                                   ` Joel Brobecker
2009-03-14 10:45                                   ` Eli Zaretskii
2009-03-14 22:09                                     ` Jan Kratochvil
2009-03-14 22:18                                       ` Eli Zaretskii
2009-03-15  9:22                                       ` Joel Brobecker
2009-03-15 18:15                                         ` Jan Kratochvil
2009-03-18  4:36                                           ` Pedro Alves
2009-03-18 14:44                                             ` Joel Brobecker
2009-03-18 15:39                                             ` Jan Kratochvil
2009-03-18 15:46                                               ` Pedro Alves
2009-02-11 22:44         ` Mark Kettenis [this message]
2009-02-12  9:41           ` Jan Kratochvil
2009-02-12 14:36             ` Pierre Muller
2009-02-12 14:44               ` Jan Kratochvil
2009-02-14 21:59             ` Mark Kettenis
2009-02-21 12:47           ` Jan Kratochvil
2009-02-21 13:44             ` Mark Kettenis
2009-02-21 15:58   ` Jan Kratochvil
2009-02-21 16:21     ` Mark Kettenis
2009-02-21 16:32       ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902112244.n1BMiK36012947@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox