PING: Get rid of linux-thread-db.c:target_beneath

PING: Get rid of linux-thread-db.c:target_beneath

[teawater]

Hi Pedro,

Sorry to disturb you.  Could you please help me review these patches?

Thanks,
Hui

On Sun, Feb 8, 2009 at 21:15, teawater <teawater@gmail.com> wrote:
>

> >
> > If you do that, you get rid of the record_beneath_to_resume,
> > record_beneath_to_wait, record_beneath_to_store_registers, etc.
> > function pointer hacks you had.  The wrinkle that has, is that your
> > method ends up responsible for doing the default if no target
> > implements the method.  IMO, that would acceptible for
> > now.  But, it can be fixed.
> >
>
> I see.
>
> So I make a new patch for it.  Could you please help me review it?
> http://sourceware.org/ml/gdb-patches/2009-02/msg00187.html
> http://sourceware.org/ml/gdb-patches/2009-02/msg00188.html
>
> And I make some new patches to fix the format errors.  Please help me review it.
> http://sourceware.org/ml/gdb-patches/2009-02/msg00189.html
> http://sourceware.org/ml/gdb-patches/2009-02/msg00190.html
> http://sourceware.org/ml/gdb-patches/2009-02/msg00192.html
>
> Thanks,
> Hui

Re: PING: Get rid of linux-thread-db.c:target_beneath

[Pedro Alves]

On Tuesday 10 February 2009 16:39:13, teawater wrote:
> Hi Pedro,
> 
> Sorry to disturb you.  Could you please help me review these patches?

Yes, I will.  It's on my queue.

> 
> Thanks,
> Hui
> 
> On Sun, Feb 8, 2009 at 21:15, teawater <teawater@gmail.com> wrote:
> >
> 
> > >
> > > If you do that, you get rid of the record_beneath_to_resume,
> > > record_beneath_to_wait, record_beneath_to_store_registers, etc.
> > > function pointer hacks you had.  The wrinkle that has, is that your
> > > method ends up responsible for doing the default if no target
> > > implements the method.  IMO, that would acceptible for
> > > now.  But, it can be fixed.
> > >
> >
> > I see.
> >
> > So I make a new patch for it.  Could you please help me review it?
> > http://sourceware.org/ml/gdb-patches/2009-02/msg00187.html
> > http://sourceware.org/ml/gdb-patches/2009-02/msg00188.html
> >
> > And I make some new patches to fix the format errors.  Please help me review it.
> > http://sourceware.org/ml/gdb-patches/2009-02/msg00189.html
> > http://sourceware.org/ml/gdb-patches/2009-02/msg00190.html
> > http://sourceware.org/ml/gdb-patches/2009-02/msg00192.html
> >
> > Thanks,
> > Hui
> 



-- 
Pedro Alves

Re: PING: Get rid of linux-thread-db.c:target_beneath

[teawater]

Thanks Pedro.

Hui

On Wed, Feb 11, 2009 at 00:41, Pedro Alves <pedro@codesourcery.com> wrote:
> On Tuesday 10 February 2009 16:39:13, teawater wrote:
>> Hi Pedro,
>>
>> Sorry to disturb you.  Could you please help me review these patches?
>
> Yes, I will.  It's on my queue.
>
>>
>> Thanks,
>> Hui
>>
>> On Sun, Feb 8, 2009 at 21:15, teawater <teawater@gmail.com> wrote:
>> >
>>
>> > >
>> > > If you do that, you get rid of the record_beneath_to_resume,
>> > > record_beneath_to_wait, record_beneath_to_store_registers, etc.
>> > > function pointer hacks you had.  The wrinkle that has, is that your
>> > > method ends up responsible for doing the default if no target
>> > > implements the method.  IMO, that would acceptible for
>> > > now.  But, it can be fixed.
>> > >
>> >
>> > I see.
>> >
>> > So I make a new patch for it.  Could you please help me review it?
>> > http://sourceware.org/ml/gdb-patches/2009-02/msg00187.html
>> > http://sourceware.org/ml/gdb-patches/2009-02/msg00188.html
>> >
>> > And I make some new patches to fix the format errors.  Please help me review it.
>> > http://sourceware.org/ml/gdb-patches/2009-02/msg00189.html
>> > http://sourceware.org/ml/gdb-patches/2009-02/msg00190.html
>> > http://sourceware.org/ml/gdb-patches/2009-02/msg00192.html
>> >
>> > Thanks,
>> > Hui
>>
>
>
>
> --
> Pedro Alves
>