From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16285 invoked by alias); 10 Feb 2009 23:57:28 -0000 Received: (qmail 16277 invoked by uid 22791); 10 Feb 2009 23:57:27 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SARE_SUB_GETRID,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.185) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Feb 2009 23:57:22 +0000 Received: by ti-out-0910.google.com with SMTP id y8so62484tia.12 for ; Tue, 10 Feb 2009 15:57:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.110.50.19 with SMTP id x19mr11753056tix.12.1234310239355; Tue, 10 Feb 2009 15:57:19 -0800 (PST) In-Reply-To: <200902101641.31900.pedro@codesourcery.com> References: <200902101641.31900.pedro@codesourcery.com> Date: Tue, 10 Feb 2009 23:57:00 -0000 Message-ID: Subject: Re: PING: Get rid of linux-thread-db.c:target_beneath From: teawater To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00228.txt.bz2 Thanks Pedro. Hui On Wed, Feb 11, 2009 at 00:41, Pedro Alves wrote: > On Tuesday 10 February 2009 16:39:13, teawater wrote: >> Hi Pedro, >> >> Sorry to disturb you. Could you please help me review these patches? > > Yes, I will. It's on my queue. > >> >> Thanks, >> Hui >> >> On Sun, Feb 8, 2009 at 21:15, teawater wrote: >> > >> >> > > >> > > If you do that, you get rid of the record_beneath_to_resume, >> > > record_beneath_to_wait, record_beneath_to_store_registers, etc. >> > > function pointer hacks you had. The wrinkle that has, is that your >> > > method ends up responsible for doing the default if no target >> > > implements the method. IMO, that would acceptible for >> > > now. But, it can be fixed. >> > > >> > >> > I see. >> > >> > So I make a new patch for it. Could you please help me review it? >> > http://sourceware.org/ml/gdb-patches/2009-02/msg00187.html >> > http://sourceware.org/ml/gdb-patches/2009-02/msg00188.html >> > >> > And I make some new patches to fix the format errors. Please help me review it. >> > http://sourceware.org/ml/gdb-patches/2009-02/msg00189.html >> > http://sourceware.org/ml/gdb-patches/2009-02/msg00190.html >> > http://sourceware.org/ml/gdb-patches/2009-02/msg00192.html >> > >> > Thanks, >> > Hui >> > > > > -- > Pedro Alves >