From: teawater <teawater@gmail.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: PING: Get rid of linux-thread-db.c:target_beneath
Date: Tue, 10 Feb 2009 23:57:00 -0000 [thread overview]
Message-ID: <daef60380902101557g2a0ce916ic1e4cea007a1356c@mail.gmail.com> (raw)
In-Reply-To: <200902101641.31900.pedro@codesourcery.com>
Thanks Pedro.
Hui
On Wed, Feb 11, 2009 at 00:41, Pedro Alves <pedro@codesourcery.com> wrote:
> On Tuesday 10 February 2009 16:39:13, teawater wrote:
>> Hi Pedro,
>>
>> Sorry to disturb you. Could you please help me review these patches?
>
> Yes, I will. It's on my queue.
>
>>
>> Thanks,
>> Hui
>>
>> On Sun, Feb 8, 2009 at 21:15, teawater <teawater@gmail.com> wrote:
>> >
>>
>> > >
>> > > If you do that, you get rid of the record_beneath_to_resume,
>> > > record_beneath_to_wait, record_beneath_to_store_registers, etc.
>> > > function pointer hacks you had. The wrinkle that has, is that your
>> > > method ends up responsible for doing the default if no target
>> > > implements the method. IMO, that would acceptible for
>> > > now. But, it can be fixed.
>> > >
>> >
>> > I see.
>> >
>> > So I make a new patch for it. Could you please help me review it?
>> > http://sourceware.org/ml/gdb-patches/2009-02/msg00187.html
>> > http://sourceware.org/ml/gdb-patches/2009-02/msg00188.html
>> >
>> > And I make some new patches to fix the format errors. Please help me review it.
>> > http://sourceware.org/ml/gdb-patches/2009-02/msg00189.html
>> > http://sourceware.org/ml/gdb-patches/2009-02/msg00190.html
>> > http://sourceware.org/ml/gdb-patches/2009-02/msg00192.html
>> >
>> > Thanks,
>> > Hui
>>
>
>
>
> --
> Pedro Alves
>
prev parent reply other threads:[~2009-02-10 23:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 16:39 teawater
2009-02-10 16:41 ` Pedro Alves
2009-02-10 23:57 ` teawater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daef60380902101557g2a0ce916ic1e4cea007a1356c@mail.gmail.com \
--to=teawater@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox