From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7080 invoked by alias); 10 Feb 2009 16:41:37 -0000 Received: (qmail 7072 invoked by uid 22791); 10 Feb 2009 16:41:36 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,SARE_SUB_GETRID,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Feb 2009 16:41:31 +0000 Received: (qmail 1658 invoked from network); 10 Feb 2009 16:41:28 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 Feb 2009 16:41:28 -0000 From: Pedro Alves To: teawater Subject: Re: PING: Get rid of linux-thread-db.c:target_beneath Date: Tue, 10 Feb 2009 16:41:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902101641.31900.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00224.txt.bz2 On Tuesday 10 February 2009 16:39:13, teawater wrote: > Hi Pedro, > > Sorry to disturb you. Could you please help me review these patches? Yes, I will. It's on my queue. > > Thanks, > Hui > > On Sun, Feb 8, 2009 at 21:15, teawater wrote: > > > > > > > > > If you do that, you get rid of the record_beneath_to_resume, > > > record_beneath_to_wait, record_beneath_to_store_registers, etc. > > > function pointer hacks you had. The wrinkle that has, is that your > > > method ends up responsible for doing the default if no target > > > implements the method. IMO, that would acceptible for > > > now. But, it can be fixed. > > > > > > > I see. > > > > So I make a new patch for it. Could you please help me review it? > > http://sourceware.org/ml/gdb-patches/2009-02/msg00187.html > > http://sourceware.org/ml/gdb-patches/2009-02/msg00188.html > > > > And I make some new patches to fix the format errors. Please help me review it. > > http://sourceware.org/ml/gdb-patches/2009-02/msg00189.html > > http://sourceware.org/ml/gdb-patches/2009-02/msg00190.html > > http://sourceware.org/ml/gdb-patches/2009-02/msg00192.html > > > > Thanks, > > Hui > -- Pedro Alves