Re: [RFA] [patch] 'info symbol' to print more info

[Joel Brobecker <brobecker@adacore.com>]

> 2008-11-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
> 
> 	* objfiles.h: New MULTI_OBJFILE_P macro.
> 	* printcmd.c (sym_info): Print object name.
> 	* maint.c (maintenance_translate_address): Likewise.

Just one comment.

> testsuite/ChangeLog
> 2008-11-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
> 
> 	* gdb.base/sepsymtab.exp: Update for new 'info sym' format.

This part looks ok to me.

> +	mapped = section_is_mapped (osect) ? "mapped" : "unmapped";

This part needs to be marked for translation as well.

> +	if (MULTI_OBJFILE_P ())
> +	  if (pc_in_unmapped_range (addr, osect))
> +	    if (section_is_overlay (osect))
> +	      printf_filtered (_("%s + %u in load address range of "
> +				 "%s overlay section %s of %s\n"),
> +			       msym_name, offset,
> +			       mapped, sec_name, obj_name);

I just want to make sure that others would agree that the "%s overlay
section" would not cause any problem for the translators. I tried to
use French as an example, and although my translation is horrible
because I don't know the French terms for these technical concepts,
I think it still showed me that it worked:

  %s + %u par rapport au bloc d'addresse de la section overlay %s dans %s

where "mapped" would have been translated to "mappée".

Anyway, as far as I can tell, as long as "mapped" and "unmapped"
are marked for translation, the patch looks good to me.

-- 
Joel