From: Joel Brobecker <brobecker@adacore.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
msnyder@vmware.com, gdb-patches@sourceware.org
Subject: Re: [RFA] [patch] 'info symbol' to print more info
Date: Sun, 16 Nov 2008 08:20:00 -0000 [thread overview]
Message-ID: <20081115190118.GL12802@adacore.com> (raw)
In-Reply-To: <8ac60eac0811151022w13df6899v13bb321ee08aae09@mail.gmail.com>
> But here, the message is already built up from 3 separate conditions,
> and I am adding one more. What you are proposing then leads to a
> chain of 16 if/then/else clauses. I don't think that's really
> appropriate ...
I haven't looked very closely at the details of the patch since Michael
and Eli already did, so I can't comment on the exact number of if
branches. But, generally speaking, we just don't have much choice if
we want to support i18n well.
That being said, I agree that 16 branches is a large number, and perhaps
we should let go of some of them. For instance, there was this discussion
about not printing the name of the objfile if MULTI_OBJFILE_P. If we
get rid of that, does it reduce the number of cases? The idea itself
is nice, but perhaps code simplicity is more important in this case.
Are there any other cosmectic features that we can get rid of to
reduce the number of cases further?
--
Joel
next prev parent reply other threads:[~2008-11-15 19:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 16:15 Paul Pluzhnikov
2008-11-15 17:00 ` Michael Snyder
2008-11-15 17:22 ` Paul Pluzhnikov
2008-11-15 18:51 ` Michael Snyder
2008-11-15 23:16 ` Paul Pluzhnikov
2008-11-15 23:35 ` Andreas Schwab
2008-11-16 1:35 ` Eli Zaretskii
2008-11-16 1:38 ` Paul Pluzhnikov
2008-11-16 8:20 ` Joel Brobecker [this message]
2008-11-17 22:37 ` Paul Pluzhnikov
2008-11-17 23:35 ` Daniel Jacobowitz
2008-11-18 16:07 ` Paul Pluzhnikov
2008-11-18 19:55 ` Eli Zaretskii
2008-11-19 4:20 ` Joel Brobecker
2008-11-19 12:45 ` Paul Pluzhnikov
2008-11-15 17:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081115190118.GL12802@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox