From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13072 invoked by alias); 18 Nov 2008 21:01:47 -0000 Received: (qmail 12967 invoked by uid 22791); 18 Nov 2008 21:01:47 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Nov 2008 21:01:10 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A5D922A9670; Tue, 18 Nov 2008 16:01:08 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rywg0Hl+TsIn; Tue, 18 Nov 2008 16:01:08 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2ACF82A966F; Tue, 18 Nov 2008 16:01:07 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id CEC9DE7ACD; Tue, 18 Nov 2008 16:01:01 -0500 (EST) Date: Wed, 19 Nov 2008 04:20:00 -0000 From: Joel Brobecker To: Paul Pluzhnikov Cc: Eli Zaretskii , msnyder@vmware.com, gdb-patches@sourceware.org Subject: Re: [RFA] [patch] 'info symbol' to print more info Message-ID: <20081118210101.GB3838@adacore.com> References: <491DF12A.5090903@vmware.com> <8ac60eac0811141406h4bb126c0sbd898e7d612f46dd@mail.gmail.com> <491E08BF.2050609@vmware.com> <8ac60eac0811150842x78206050t435c6f8c89ddc8ae@mail.gmail.com> <8ac60eac0811151022w13df6899v13bb321ee08aae09@mail.gmail.com> <20081115190118.GL12802@adacore.com> <8ac60eac0811171112x5b555146lefb27f36e773ac25@mail.gmail.com> <20081117193531.GA17547@caradoc.them.org> <8ac60eac0811171536m1ac412f0k934c5acd5a1cc1f4@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8ac60eac0811171536m1ac412f0k934c5acd5a1cc1f4@mail.gmail.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00482.txt.bz2 > 2008-11-17 Paul Pluzhnikov > > * objfiles.h: New MULTI_OBJFILE_P macro. > * printcmd.c (sym_info): Print object name. > * maint.c (maintenance_translate_address): Likewise. Just one comment. > testsuite/ChangeLog > 2008-11-17 Paul Pluzhnikov > > * gdb.base/sepsymtab.exp: Update for new 'info sym' format. This part looks ok to me. > + mapped = section_is_mapped (osect) ? "mapped" : "unmapped"; This part needs to be marked for translation as well. > + if (MULTI_OBJFILE_P ()) > + if (pc_in_unmapped_range (addr, osect)) > + if (section_is_overlay (osect)) > + printf_filtered (_("%s + %u in load address range of " > + "%s overlay section %s of %s\n"), > + msym_name, offset, > + mapped, sec_name, obj_name); I just want to make sure that others would agree that the "%s overlay section" would not cause any problem for the translators. I tried to use French as an example, and although my translation is horrible because I don't know the French terms for these technical concepts, I think it still showed me that it worked: %s + %u par rapport au bloc d'addresse de la section overlay %s dans %s where "mapped" would have been translated to "mappée". Anyway, as far as I can tell, as long as "mapped" and "unmapped" are marked for translation, the patch looks good to me. -- Joel