Re: Overlay support broken (Re: [patch] [2/2] Discontiguous PSYMTABs (psymtabs->symtabs by addrmap))

["Ulrich Weigand" <uweigand@de.ibm.com>]

Jan Kratochvil wrote:
> On Tue, 13 May 2008 19:00:48 +0200, Ulrich Weigand wrote:
> ...
> > Which parts of GDB do you think do not support overlays?  I'd be interested
> > in fixing such problems ...
> 
> There is still a lot of stub functions X() just calling X_sect() using
> find_pc_mapped_section(), these should get removed as otherwise one may find
> a countercase where it fails for the overlayed sections.
> [blockvector_for_pc, block_for_pc, find_pc_psymtab, find_pc_psymbol,
>  find_pc_symtab, find_pc_section, find_pc_function]

I thought those remaining usages were generally OK -- but I guess you're
right that new uses may have crept in over time ...

> > For now, I'm using the patch below that simply falls back to the non-addrmap
> > case when debugging overlays and the addrmap returned the wrong section.
> 
> I started coding a similiar patch as IMO the overlayed sections have no use for
> addrmap as they are not discontiguous, thanks for fixing it up this way.

Hmm, OK.  However, even with overlay debugging, there might be some other
discontiguous sections, so I don't really like the
  if (overlay_debugging ...)
aspect of my patch.  But without that condition, one of your new test cases
would fail again.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com