From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6427 invoked by alias); 15 May 2008 16:39:32 -0000 Received: (qmail 6416 invoked by uid 22791); 15 May 2008 16:39:31 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 15 May 2008 16:39:10 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id m4FGcnFZ124826 for ; Thu, 15 May 2008 16:38:49 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m4FGcn2K3424454 for ; Thu, 15 May 2008 18:38:49 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m4FGcmJ1026240 for ; Thu, 15 May 2008 18:38:49 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m4FGcmvr026237; Thu, 15 May 2008 18:38:48 +0200 Message-Id: <200805151638.m4FGcmvr026237@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 15 May 2008 18:38:48 +0200 Subject: Re: Overlay support broken (Re: [patch] [2/2] Discontiguous PSYMTABs (psymtabs->symtabs by addrmap)) To: jan.kratochvil@redhat.com (Jan Kratochvil) Date: Thu, 15 May 2008 18:16:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sources.redhat.com, drow@false.org In-Reply-To: <20080515101100.GA3624@host0.dyn.jankratochvil.net> from "Jan Kratochvil" at May 15, 2008 12:11:00 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00468.txt.bz2 Jan Kratochvil wrote: > On Tue, 13 May 2008 19:00:48 +0200, Ulrich Weigand wrote: > ... > > Which parts of GDB do you think do not support overlays? I'd be interested > > in fixing such problems ... > > There is still a lot of stub functions X() just calling X_sect() using > find_pc_mapped_section(), these should get removed as otherwise one may find > a countercase where it fails for the overlayed sections. > [blockvector_for_pc, block_for_pc, find_pc_psymtab, find_pc_psymbol, > find_pc_symtab, find_pc_section, find_pc_function] I thought those remaining usages were generally OK -- but I guess you're right that new uses may have crept in over time ... > > For now, I'm using the patch below that simply falls back to the non-addrmap > > case when debugging overlays and the addrmap returned the wrong section. > > I started coding a similiar patch as IMO the overlayed sections have no use for > addrmap as they are not discontiguous, thanks for fixing it up this way. Hmm, OK. However, even with overlay debugging, there might be some other discontiguous sections, so I don't really like the if (overlay_debugging ...) aspect of my patch. But without that condition, one of your new test cases would fail again. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com