From: Michael Snyder <msnyder@specifix.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Overlay support broken (Re: [patch] [2/2] Discontiguous PSYMTABs (psymtabs->symtabs by addrmap))
Date: Thu, 15 May 2008 19:18:00 -0000 [thread overview]
Message-ID: <1210875572.4615.607.camel@localhost.localdomain> (raw)
In-Reply-To: <20080515101100.GA3624@host0.dyn.jankratochvil.net>
On Thu, 2008-05-15 at 12:11 +0200, Jan Kratochvil wrote:
> On Tue, 13 May 2008 19:00:48 +0200, Ulrich Weigand wrote:
> ...
> > Which parts of GDB do you think do not support overlays? I'd be interested
> > in fixing such problems ...
>
> There is still a lot of stub functions X() just calling X_sect() using
> find_pc_mapped_section(), these should get removed as otherwise one may find
> a countercase where it fails for the overlayed sections.
> [blockvector_for_pc, block_for_pc, find_pc_psymtab, find_pc_psymbol,
> find_pc_symtab, find_pc_section, find_pc_function]
? It's been 10 years, but I think that's the way it is
supposed to work.
Old code calls X(), without supplying a section.
Then X forwards the call to X_sect() after attempting
to lookup the appropriate section.
In most cases this should not be critical for overlays,
because code that depends on overlays should be calling
X_sect() directly. It was just a shortcut so that we
wouldn't have to change all the calls of X into X_sect
(and do the section lookup in many places instead of one).
next prev parent reply other threads:[~2008-05-15 18:19 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 18:17 [patch] Parse DW_AT_ranges into PSYMTABS (for childless CU, for vDSO32) Jan Kratochvil
2007-10-09 18:22 ` Daniel Jacobowitz
2007-10-09 18:59 ` Jan Kratochvil
2007-10-09 19:13 ` Daniel Jacobowitz
2007-11-24 15:43 ` Jan Kratochvil
2007-11-25 14:48 ` Daniel Jacobowitz
2007-11-30 7:42 ` Vladimir Prus
2007-11-30 11:10 ` Jan Kratochvil
2007-11-30 14:56 ` Daniel Jacobowitz
2007-11-30 15:09 ` Jan Kratochvil
2007-12-01 0:55 ` Jim Blandy
2007-12-01 17:30 ` Joel Brobecker
2007-12-09 20:40 ` [patch] Discontiguous PSYMTABs [Re: [patch] Parse DW_AT_ranges into PSYMTABS (for childless CU, for vDSO32)] Jan Kratochvil
2007-12-10 0:21 ` [patch] Removal of the FIND_PC_SECT_PSYMTAB search [Re: [patch] Discontiguous PSYMTABs] Jan Kratochvil
2007-12-17 1:02 ` [patch] Discontiguous PSYMTABs [Re: [patch] Parse DW_AT_ranges into PSYMTABS (for childless CU, for vDSO32)] Daniel Jacobowitz
2007-12-17 1:03 ` Daniel Jacobowitz
2007-12-17 2:41 ` [patch] Discontiguous PSYMTABs Jan Kratochvil
2007-12-17 3:41 ` Daniel Jacobowitz
2008-04-23 22:15 ` [patch] [0/2] " Jan Kratochvil
2008-04-23 22:18 ` [patch] [1/2] Discontiguous PSYMTABs (partial DIEs base address) Jan Kratochvil
2008-05-01 19:43 ` Daniel Jacobowitz
2008-04-23 22:24 ` [patch] [2/2] Discontiguous PSYMTABs (psymtabs->symtabs by addrmap) Jan Kratochvil
2008-05-01 19:46 ` Daniel Jacobowitz
2008-05-04 17:38 ` Jan Kratochvil
2008-05-12 22:24 ` Overlay support broken (Re: [patch] [2/2] Discontiguous PSYMTABs (psymtabs->symtabs by addrmap)) Ulrich Weigand
2008-05-12 22:37 ` Michael Snyder
2008-05-13 1:39 ` Daniel Jacobowitz
2008-05-13 3:17 ` Jan Kratochvil
2008-05-13 15:37 ` Doug Evans
2008-05-13 15:42 ` Michael Snyder
2008-05-13 15:31 ` Doug Evans
2008-05-12 23:52 ` Jan Kratochvil
2008-05-13 18:45 ` Ulrich Weigand
2008-05-13 19:08 ` Pedro Alves
2008-05-13 19:01 ` Pedro Alves
2008-05-13 19:11 ` Michael Snyder
2008-05-15 16:39 ` Jan Kratochvil
2008-05-15 18:16 ` Ulrich Weigand
2008-05-15 18:44 ` Daniel Jacobowitz
2008-05-15 19:06 ` Ulrich Weigand
2008-05-16 18:32 ` Ulrich Weigand
2008-05-15 19:18 ` Michael Snyder [this message]
2008-04-23 21:31 ` [patch] Discontiguous PSYMTABs [Re: [patch] Parse DW_AT_ranges into PSYMTABS (for childless CU, for vDSO32)] Doug Evans
2008-04-23 21:31 ` Jan Kratochvil
2008-05-14 1:11 Overlay support broken (Re: [patch] [2/2] Discontiguous PSYMTABs (psymtabs->symtabs by addrmap)) Ulrich Weigand
2008-05-14 8:07 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210875572.4615.607.camel@localhost.localdomain \
--to=msnyder@specifix.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox