From: Daniel Jacobowitz <drow@false.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>,
gdb-patches@sources.redhat.com,
Jim Blandy <jimb@codesourcery.com>,
Vladimir Prus <ghost@cs.msu.su>
Subject: Re: [patch] Discontiguous PSYMTABs [Re: [patch] Parse DW_AT_ranges into PSYMTABS (for childless CU, for vDSO32)]
Date: Mon, 17 Dec 2007 01:03:00 -0000 [thread overview]
Message-ID: <20071217010217.GB14690@caradoc.them.org> (raw)
In-Reply-To: <20071217005641.GA14690@caradoc.them.org>
On Sun, Dec 16, 2007 at 07:56:41PM -0500, Daniel Jacobowitz wrote:
> On Sun, Dec 09, 2007 at 09:31:38PM +0100, Jan Kratochvil wrote:
> > Attaching the fix for discontiguous psymtabs based on the addrmap framework.
> >
> > This one is a conservative one - it tries to just fix it with minimal changes.
> > It is bidirectionally compatible:
> > * Producer (dwarf2read.c) still tries to set the bounds TEXTLOW and TEXTHIGH.
> > * Consumer (symtab.c) deals with both set and unset PSYMTABS_ADDRMAP.
>
> This looks OK to me. Thanks for doing it!
Oops, maybe not. I've just thought of another case where we might
have trouble. What if one file contains DW_AT_ranges and another file
only contains stabs?
If we trust the addrmap, will we still find the file with stabs? We
may need to fall through.
I'm sure there are some old versions of GCC which generated
DW_AT_high_pc / DW_AT_low_pc when they should have generated
DW_AT_ranges. Hopefully we do not need to cater to that. However,
stabs has no way to represent range information.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-12-17 1:02 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 18:17 [patch] Parse DW_AT_ranges into PSYMTABS (for childless CU, for vDSO32) Jan Kratochvil
2007-10-09 18:22 ` Daniel Jacobowitz
2007-10-09 18:59 ` Jan Kratochvil
2007-10-09 19:13 ` Daniel Jacobowitz
2007-11-24 15:43 ` Jan Kratochvil
2007-11-25 14:48 ` Daniel Jacobowitz
2007-11-30 7:42 ` Vladimir Prus
2007-11-30 11:10 ` Jan Kratochvil
2007-11-30 14:56 ` Daniel Jacobowitz
2007-11-30 15:09 ` Jan Kratochvil
2007-12-01 0:55 ` Jim Blandy
2007-12-01 17:30 ` Joel Brobecker
2007-12-09 20:40 ` [patch] Discontiguous PSYMTABs [Re: [patch] Parse DW_AT_ranges into PSYMTABS (for childless CU, for vDSO32)] Jan Kratochvil
2007-12-10 0:21 ` [patch] Removal of the FIND_PC_SECT_PSYMTAB search [Re: [patch] Discontiguous PSYMTABs] Jan Kratochvil
2007-12-17 1:02 ` [patch] Discontiguous PSYMTABs [Re: [patch] Parse DW_AT_ranges into PSYMTABS (for childless CU, for vDSO32)] Daniel Jacobowitz
2007-12-17 1:03 ` Daniel Jacobowitz [this message]
2007-12-17 2:41 ` [patch] Discontiguous PSYMTABs Jan Kratochvil
2007-12-17 3:41 ` Daniel Jacobowitz
2008-04-23 22:15 ` [patch] [0/2] " Jan Kratochvil
2008-04-23 22:18 ` [patch] [1/2] Discontiguous PSYMTABs (partial DIEs base address) Jan Kratochvil
2008-05-01 19:43 ` Daniel Jacobowitz
2008-04-23 22:24 ` [patch] [2/2] Discontiguous PSYMTABs (psymtabs->symtabs by addrmap) Jan Kratochvil
2008-05-01 19:46 ` Daniel Jacobowitz
2008-05-04 17:38 ` Jan Kratochvil
2008-05-12 22:24 ` Overlay support broken (Re: [patch] [2/2] Discontiguous PSYMTABs (psymtabs->symtabs by addrmap)) Ulrich Weigand
2008-05-12 22:37 ` Michael Snyder
2008-05-13 1:39 ` Daniel Jacobowitz
2008-05-13 3:17 ` Jan Kratochvil
2008-05-13 15:37 ` Doug Evans
2008-05-13 15:42 ` Michael Snyder
2008-05-13 15:31 ` Doug Evans
2008-05-12 23:52 ` Jan Kratochvil
2008-05-13 18:45 ` Ulrich Weigand
2008-05-13 19:08 ` Pedro Alves
2008-05-13 19:01 ` Pedro Alves
2008-05-13 19:11 ` Michael Snyder
2008-05-15 16:39 ` Jan Kratochvil
2008-05-15 18:16 ` Ulrich Weigand
2008-05-15 18:44 ` Daniel Jacobowitz
2008-05-15 19:06 ` Ulrich Weigand
2008-05-16 18:32 ` Ulrich Weigand
2008-05-15 19:18 ` Michael Snyder
2008-04-23 21:31 ` [patch] Discontiguous PSYMTABs [Re: [patch] Parse DW_AT_ranges into PSYMTABS (for childless CU, for vDSO32)] Doug Evans
2008-04-23 21:31 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071217010217.GB14690@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
--cc=jan.kratochvil@redhat.com \
--cc=jimb@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox