From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23922 invoked by alias); 17 Dec 2007 01:02:36 -0000 Received: (qmail 23903 invoked by uid 22791); 17 Dec 2007 01:02:27 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Dec 2007 01:02:20 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 6CD2F98129; Mon, 17 Dec 2007 01:02:18 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 390559811F; Mon, 17 Dec 2007 01:02:18 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1J44N7-00041X-Hm; Sun, 16 Dec 2007 20:02:17 -0500 Date: Mon, 17 Dec 2007 01:03:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil , gdb-patches@sources.redhat.com, Jim Blandy , Vladimir Prus Subject: Re: [patch] Discontiguous PSYMTABs [Re: [patch] Parse DW_AT_ranges into PSYMTABS (for childless CU, for vDSO32)] Message-ID: <20071217010217.GB14690@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , gdb-patches@sources.redhat.com, Jim Blandy , Vladimir Prus References: <20071009180246.GA26829@host0.dyn.jankratochvil.net> <20071009181701.GA30757@caradoc.them.org> <20071009185434.GA27810@host0.dyn.jankratochvil.net> <20071009185931.GA1220@caradoc.them.org> <20071124154339.GA14913@host0.dyn.jankratochvil.net> <20071130111021.GA17867@host0.dyn.jankratochvil.net> <20071130145613.GA5941@caradoc.them.org> <20071209203138.GA23339@host0.dyn.jankratochvil.net> <20071217005641.GA14690@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071217005641.GA14690@caradoc.them.org> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00249.txt.bz2 On Sun, Dec 16, 2007 at 07:56:41PM -0500, Daniel Jacobowitz wrote: > On Sun, Dec 09, 2007 at 09:31:38PM +0100, Jan Kratochvil wrote: > > Attaching the fix for discontiguous psymtabs based on the addrmap framework. > > > > This one is a conservative one - it tries to just fix it with minimal changes. > > It is bidirectionally compatible: > > * Producer (dwarf2read.c) still tries to set the bounds TEXTLOW and TEXTHIGH. > > * Consumer (symtab.c) deals with both set and unset PSYMTABS_ADDRMAP. > > This looks OK to me. Thanks for doing it! Oops, maybe not. I've just thought of another case where we might have trouble. What if one file contains DW_AT_ranges and another file only contains stabs? If we trust the addrmap, will we still find the file with stabs? We may need to fall through. I'm sure there are some old versions of GCC which generated DW_AT_high_pc / DW_AT_low_pc when they should have generated DW_AT_ranges. Hopefully we do not need to cater to that. However, stabs has no way to represent range information. -- Daniel Jacobowitz CodeSourcery