[commit/obvious] fix findcmd.c build failure on Tru64

[commit/obvious] fix findcmd.c build failure on Tru64

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

Hello,

I just checked in the attached patch.  The issue was that the code is
using some types such as int32_t which are normally declared in stdint.h.
So I added a #include of gdb_stdint.h.

2008-05-13  Joel Brobecker  <brobecker@adacore.com>

        * findcmd.c: Add #include "gdb_stdint.h".
        * Makefile.in (findcmd.o): Update dependencies.

-- 
Joel

[-- Attachment #2: osf.diff --]
[-- Type: text/plain, Size: 1163 bytes --]

Index: findcmd.c
===================================================================
RCS file: /cvs/src/src/gdb/findcmd.c,v
retrieving revision 1.2
diff -u -p -r1.2 findcmd.c
--- findcmd.c	9 May 2008 17:37:36 -0000	1.2
+++ findcmd.c	14 May 2008 04:20:46 -0000
@@ -23,6 +23,7 @@
 #include "gdbcmd.h"
 #include "value.h"
 #include "target.h"
+#include "gdb_stdint.h"
 
 /* Copied from bfd_put_bits.  */
 
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1018
diff -u -p -r1.1018 Makefile.in
--- Makefile.in	9 May 2008 17:02:01 -0000	1.1018
+++ Makefile.in	14 May 2008 04:20:47 -0000
@@ -2137,7 +2137,7 @@ f-exp.o: f-exp.c $(defs_h) $(gdb_string_
 	$(parser_defs_h) $(language_h) $(f_lang_h) $(bfd_h) $(symfile_h) \
 	$(objfiles_h) $(block_h)
 findcmd.o: findcmd.c $(defs_h) $(gdb_string_h) $(gdbcmd_h) $(value_h) \
-	$(target_h)
+	$(target_h) $(gdb_stdint_h)
 findvar.o: findvar.c $(defs_h) $(symtab_h) $(gdbtypes_h) $(frame_h) \
 	$(value_h) $(gdbcore_h) $(inferior_h) $(target_h) $(gdb_string_h) \
 	$(gdb_assert_h) $(floatformat_h) $(symfile_h) $(regcache_h) \

Re: [commit/obvious] fix findcmd.c build failure on Tru64

[Joel Brobecker]

> I just checked in the attached patch.  The issue was that the code is
> using some types such as int32_t which are normally declared in stdint.h.
> So I added a #include of gdb_stdint.h.

Ooops, forgot to ask my question :-).

The types in question seem to be only used together with the sizeof
operator. Could we have simply used 8 instead of sizeof (int64_t)?
Looking at the C90 draft that I have, my understanding is that
intN_t types are required to be exactly N bits.

(not that this is really all that important, but I need to improve
my C skills).
-- 
Joel

Re: [commit/obvious] fix findcmd.c build failure on Tru64

[Daniel Jacobowitz]

On Tue, May 13, 2008 at 09:30:35PM -0700, Joel Brobecker wrote:
> The types in question seem to be only used together with the sizeof
> operator. Could we have simply used 8 instead of sizeof (int64_t)?
> Looking at the C90 draft that I have, my understanding is that
> intN_t types are required to be exactly N bits.

I think that's true, but it seems nicer this way.

I'll ask the opposite question.  Can we just put stdint.h in defs.h
now?  It's clear that gdb_stdint.h works everywhere; there's also a
stdint.h in our build tree provided by gnulib if the system lacks its
own.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [commit/obvious] fix findcmd.c build failure on Tru64

[Joel Brobecker]

> I'll ask the opposite question.  Can we just put stdint.h in defs.h
> now?  It's clear that gdb_stdint.h works everywhere; there's also a
> stdint.h in our build tree provided by gnulib if the system lacks its
> own.

I don't see why not... Should we drop gdb_stdint.h and use stdint.h
directly, then?

-- 
Joel