From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32427 invoked by alias); 14 May 2008 11:51:36 -0000 Received: (qmail 32411 invoked by uid 22791); 14 May 2008 11:51:34 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 14 May 2008 11:51:14 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id C8125983FA; Wed, 14 May 2008 11:51:12 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id A3BFB983F9; Wed, 14 May 2008 11:51:12 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JwFVn-0001mX-Pq; Wed, 14 May 2008 07:51:11 -0400 Date: Wed, 14 May 2008 18:10:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [commit/obvious] fix findcmd.c build failure on Tru64 Message-ID: <20080514115111.GA6716@caradoc.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20080514042628.GA3727@adacore.com> <20080514043035.GA3643@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080514043035.GA3643@adacore.com> User-Agent: Mutt/1.5.17 (2008-05-05) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00430.txt.bz2 On Tue, May 13, 2008 at 09:30:35PM -0700, Joel Brobecker wrote: > The types in question seem to be only used together with the sizeof > operator. Could we have simply used 8 instead of sizeof (int64_t)? > Looking at the C90 draft that I have, my understanding is that > intN_t types are required to be exactly N bits. I think that's true, but it seems nicer this way. I'll ask the opposite question. Can we just put stdint.h in defs.h now? It's clear that gdb_stdint.h works everywhere; there's also a stdint.h in our build tree provided by gnulib if the system lacks its own. -- Daniel Jacobowitz CodeSourcery