From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4029 invoked by alias); 14 May 2008 04:30:57 -0000 Received: (qmail 4020 invoked by uid 22791); 14 May 2008 04:30:57 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 14 May 2008 04:30:39 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E379B2A98A6 for ; Wed, 14 May 2008 00:30:37 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id hiZp2V1zxt+E for ; Wed, 14 May 2008 00:30:37 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A99372A989B for ; Wed, 14 May 2008 00:30:37 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id C3253E7ACD; Tue, 13 May 2008 21:30:35 -0700 (PDT) Date: Wed, 14 May 2008 18:01:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [commit/obvious] fix findcmd.c build failure on Tru64 Message-ID: <20080514043035.GA3643@adacore.com> References: <20080514042628.GA3727@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080514042628.GA3727@adacore.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00427.txt.bz2 > I just checked in the attached patch. The issue was that the code is > using some types such as int32_t which are normally declared in stdint.h. > So I added a #include of gdb_stdint.h. Ooops, forgot to ask my question :-). The types in question seem to be only used together with the sizeof operator. Could we have simply used 8 instead of sizeof (int64_t)? Looking at the C90 draft that I have, my understanding is that intN_t types are required to be exactly N bits. (not that this is really all that important, but I need to improve my C skills). -- Joel