From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [commit/obvious] fix findcmd.c build failure on Tru64
Date: Wed, 14 May 2008 18:01:00 -0000 [thread overview]
Message-ID: <20080514043035.GA3643@adacore.com> (raw)
In-Reply-To: <20080514042628.GA3727@adacore.com>
> I just checked in the attached patch. The issue was that the code is
> using some types such as int32_t which are normally declared in stdint.h.
> So I added a #include of gdb_stdint.h.
Ooops, forgot to ask my question :-).
The types in question seem to be only used together with the sizeof
operator. Could we have simply used 8 instead of sizeof (int64_t)?
Looking at the C90 draft that I have, my understanding is that
intN_t types are required to be exactly N bits.
(not that this is really all that important, but I need to improve
my C skills).
--
Joel
next prev parent reply other threads:[~2008-05-14 4:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 17:56 Joel Brobecker
2008-05-14 18:01 ` Joel Brobecker [this message]
2008-05-14 18:10 ` Daniel Jacobowitz
2008-05-14 18:13 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080514043035.GA3643@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox