Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA/commit/Ada] Replace home-made string_vector struct with VEC
Date: Thu, 07 Feb 2008 19:14:00 -0000	[thread overview]
Message-ID: <20080207191338.GD3907@adacore.com> (raw)
In-Reply-To: <20080206015703.GA16367@adacore.com>

> 2007-02-05  Joel Brobecker  <brobecker@adacore.com>
> 
>         * ada-lang.c: #include "vec.h".
>         (struct string_vector, new_string_vector, string_vector_append):
>         Delete.
>         (char_ptr): New typedef.
>         (DEF_VEC_P (char_ptr)): New VEC type.
>         (symbol_completion_add): Update profile to take the new VEC type
>         instead of the old string_vector structure. Update code accordingly.
>         (ada_make_symbol_completion_list): Use the new VEC type instead of
>         the old string_vector structure, and update the code accordingly.
>         * Makefile.in (ada-lang.o): Add dependency on vec.h.

I just checked this one in.

> >   1. Would it make sense to have standard VECs predefined somewhere?
> >      For instance, I wonder how often a VEC of strings will be useful
> >      in GDB...
> 
> Sounds reasonable to me.

OK. Let's reserve the idea for now until we notice the same VECs
being used in several places...

-- 
Joel


      parent reply	other threads:[~2008-02-07 19:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-28 13:07 [RFA] Make symbol completion language-specific Joel Brobecker
2008-01-29 17:35 ` Daniel Jacobowitz
2008-01-30 20:43   ` Joel Brobecker
2008-01-30 21:25     ` Daniel Jacobowitz
2008-02-04 23:15   ` Joel Brobecker
2008-02-04 23:30     ` Daniel Jacobowitz
2008-02-05 22:32       ` Joel Brobecker
2008-02-06  2:40         ` [RFA/commit/Ada] Replace home-made string_vector struct with VEC Joel Brobecker
2008-02-06  2:48           ` Daniel Jacobowitz
2008-02-07 19:14           ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080207191338.GD3907@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox