From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit/Ada] Replace home-made string_vector struct with VEC
Date: Wed, 06 Feb 2008 02:48:00 -0000 [thread overview]
Message-ID: <20080206024747.GA24828@caradoc.them.org> (raw)
In-Reply-To: <20080206015703.GA16367@adacore.com>
On Tue, Feb 05, 2008 at 05:57:03PM -0800, Joel Brobecker wrote:
> 1. Would it make sense to have standard VECs predefined somewhere?
> For instance, I wonder how often a VEC of strings will be useful
> in GDB...
Sounds reasonable to me.
> 2. Would it make sense to expand the VEC API to have a method
> that will return a copy of the underlying array? After some
> thoughts, and a look at the current usage, it seemed to me
> that it didn't make much sense. I didn't see any other places
> where we need to make that copy, and making that copy is
> pretty simple.
I agree. The memory allocation doesn't work out to make this
advantageous.
If we want to save the copy, allowing some other way to register a
destructor for the array might do more good.
Thanks!
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-02-06 2:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-28 13:07 [RFA] Make symbol completion language-specific Joel Brobecker
2008-01-29 17:35 ` Daniel Jacobowitz
2008-01-30 20:43 ` Joel Brobecker
2008-01-30 21:25 ` Daniel Jacobowitz
2008-02-04 23:15 ` Joel Brobecker
2008-02-04 23:30 ` Daniel Jacobowitz
2008-02-05 22:32 ` Joel Brobecker
2008-02-06 2:40 ` [RFA/commit/Ada] Replace home-made string_vector struct with VEC Joel Brobecker
2008-02-06 2:48 ` Daniel Jacobowitz [this message]
2008-02-07 19:14 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080206024747.GA24828@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox