Re: [RFA] Make symbol completion language-specific

[Joel Brobecker <brobecker@adacore.com>]

Hi Daniel,

> > +struct string_vector
> > +{
> > +  char **array; /* The vector itself.  */
> > +  int index;    /* Index of the next available element in the array.  */
> > +  size_t size;  /* The number of entries allocated in the array.  */
> > +};
> 
> We have a generic VEC nowadays.

I just had a look, and I don't think the generic VEC integrates itself
well with the current infrastructure.  The type above works well,
because I can then directly pass the char **array back to the caller
of our completion routine (one of the callers is responsible for
freeing it - see completer.c:line_completion_function).

If I were to use a VEC, I would have to return a copy of the contents
of the VEC, which seems silly because I'd end up immediately destroying
an array that I just copied.

I propose the following:

  - I check the current patch in, as is (with an extra comment
    explaining why we're not using a VEC).

  - I can work on a follow-up patch that changes the inferface of
    the completer to use VECs instead of a NULL-terminated arrays.
    It's unclear how much benefit it's going to bring, but I could
    work on that relatively soon.

Thanks,
-- 
Joel