From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14167 invoked by alias); 7 Feb 2008 19:14:04 -0000 Received: (qmail 14136 invoked by uid 22791); 7 Feb 2008 19:14:02 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 07 Feb 2008 19:13:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8BC952AA88E for ; Thu, 7 Feb 2008 14:13:41 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lXyqEYKxwIYr for ; Thu, 7 Feb 2008 14:13:41 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 545AB2AA88B for ; Thu, 7 Feb 2008 14:13:41 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 00E9AE7ACB; Thu, 7 Feb 2008 11:13:38 -0800 (PST) Date: Thu, 07 Feb 2008 19:14:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [RFA/commit/Ada] Replace home-made string_vector struct with VEC Message-ID: <20080207191338.GD3907@adacore.com> References: <20071228122825.GC24450@adacore.com> <20080129172800.GA3773@caradoc.them.org> <20080204231510.GI21614@adacore.com> <20080204232951.GA31411@caradoc.them.org> <20080205223151.GA3727@adacore.com> <20080206015703.GA16367@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080206015703.GA16367@adacore.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00135.txt.bz2 > 2007-02-05 Joel Brobecker > > * ada-lang.c: #include "vec.h". > (struct string_vector, new_string_vector, string_vector_append): > Delete. > (char_ptr): New typedef. > (DEF_VEC_P (char_ptr)): New VEC type. > (symbol_completion_add): Update profile to take the new VEC type > instead of the old string_vector structure. Update code accordingly. > (ada_make_symbol_completion_list): Use the new VEC type instead of > the old string_vector structure, and update the code accordingly. > * Makefile.in (ada-lang.o): Add dependency on vec.h. I just checked this one in. > > 1. Would it make sense to have standard VECs predefined somewhere? > > For instance, I wonder how often a VEC of strings will be useful > > in GDB... > > Sounds reasonable to me. OK. Let's reserve the idea for now until we notice the same VECs being used in several places... -- Joel