[RFA] Remove defs.h #include in rs6000-tdep.h

[RFA] Remove defs.h #include in rs6000-tdep.h

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

This is the only other #include of defs.h in a .h file that I could find,
and I wouldn't mind a second look.

I noticed that it was also missing an opaque declaration of struct
frame_info, so I added it as well.

2007-12-20  Joel Brobecker  <brobecker@adacore.com>

        * rs6000-tdep.h: Remove defs.h #include.
        (struct frame_info): Add opaque declaration.
        * Makefile.in (rs6000_tdep_h): Update dependencies.

Tested by rebuilding on powerpc-aix.
Does it look OK?

Thanks,
-- 
Joel

[-- Attachment #2: rs6000.diff --]
[-- Type: text/plain, Size: 1152 bytes --]

Index: rs6000-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.h,v
retrieving revision 1.7
diff -u -p -r1.7 rs6000-tdep.h
--- rs6000-tdep.h	23 Aug 2007 18:08:37 -0000	1.7
+++ rs6000-tdep.h	20 Dec 2007 06:01:23 -0000
@@ -17,7 +17,8 @@
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
-#include "defs.h"
+/* Opaque declarations.  */
+struct frame_info;
 
 extern int rs6000_software_single_step (struct frame_info *frame);
 
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.968
diff -u -p -r1.968 Makefile.in
--- Makefile.in	20 Dec 2007 05:36:14 -0000	1.968
+++ Makefile.in	20 Dec 2007 05:59:46 -0000
@@ -855,7 +855,7 @@ reggroups_h = reggroups.h
 regset_h = regset.h
 remote_fileio_h = remote-fileio.h
 remote_h = remote.h
-rs6000_tdep_h = rs6000-tdep.h $(defs_h)
+rs6000_tdep_h = rs6000-tdep.h
 s390_tdep_h = s390-tdep.h
 scm_lang_h = scm-lang.h $(scm_tags_h)
 scm_tags_h = scm-tags.h

Re: [RFA] Remove defs.h #include in rs6000-tdep.h

[Mark Kettenis]

> Date: Thu, 20 Dec 2007 19:46:20 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> 
> This is the only other #include of defs.h in a .h file that I could find,
> and I wouldn't mind a second look.

Looks ok.

> I noticed that it was also missing an opaque declaration of struct
> frame_info, so I added it as well.

There is one in "defs.h", but it doesn't hurt.

> 2007-12-20  Joel Brobecker  <brobecker@adacore.com>
> 
>         * rs6000-tdep.h: Remove defs.h #include.
>         (struct frame_info): Add opaque declaration.
>         * Makefile.in (rs6000_tdep_h): Update dependencies.

Re: [RFA] Remove defs.h #include in rs6000-tdep.h

[Joel Brobecker]

> Looks ok.

Thanks for looking at it, Mark.

> > I noticed that it was also missing an opaque declaration of struct
> > frame_info, so I added it as well.
> 
> There is one in "defs.h", but it doesn't hurt.

Might as well do things right. So I removed it, re-built just in case,
and committed the change.

Thanks again,
-- 
Joel