From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: [RFA] Remove defs.h #include in rs6000-tdep.h
Date: Thu, 20 Dec 2007 15:47:00 -0000 [thread overview]
Message-ID: <20071220154620.GG6184@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
This is the only other #include of defs.h in a .h file that I could find,
and I wouldn't mind a second look.
I noticed that it was also missing an opaque declaration of struct
frame_info, so I added it as well.
2007-12-20 Joel Brobecker <brobecker@adacore.com>
* rs6000-tdep.h: Remove defs.h #include.
(struct frame_info): Add opaque declaration.
* Makefile.in (rs6000_tdep_h): Update dependencies.
Tested by rebuilding on powerpc-aix.
Does it look OK?
Thanks,
--
Joel
[-- Attachment #2: rs6000.diff --]
[-- Type: text/plain, Size: 1152 bytes --]
Index: rs6000-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.h,v
retrieving revision 1.7
diff -u -p -r1.7 rs6000-tdep.h
--- rs6000-tdep.h 23 Aug 2007 18:08:37 -0000 1.7
+++ rs6000-tdep.h 20 Dec 2007 06:01:23 -0000
@@ -17,7 +17,8 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
-#include "defs.h"
+/* Opaque declarations. */
+struct frame_info;
extern int rs6000_software_single_step (struct frame_info *frame);
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.968
diff -u -p -r1.968 Makefile.in
--- Makefile.in 20 Dec 2007 05:36:14 -0000 1.968
+++ Makefile.in 20 Dec 2007 05:59:46 -0000
@@ -855,7 +855,7 @@ reggroups_h = reggroups.h
regset_h = regset.h
remote_fileio_h = remote-fileio.h
remote_h = remote.h
-rs6000_tdep_h = rs6000-tdep.h $(defs_h)
+rs6000_tdep_h = rs6000-tdep.h
s390_tdep_h = s390-tdep.h
scm_lang_h = scm-lang.h $(scm_tags_h)
scm_tags_h = scm-tags.h
next reply other threads:[~2007-12-20 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 15:47 Joel Brobecker [this message]
2007-12-20 16:37 ` Mark Kettenis
2007-12-21 6:07 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071220154620.GG6184@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox