From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13010 invoked by alias); 20 Dec 2007 15:46:44 -0000 Received: (qmail 13001 invoked by uid 22791); 20 Dec 2007 15:46:43 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Dec 2007 15:46:32 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 194912A9690 for ; Thu, 20 Dec 2007 10:46:30 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id KgXfwGW3oESm for ; Thu, 20 Dec 2007 10:46:30 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7B0F42A968E for ; Thu, 20 Dec 2007 10:46:29 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 7F743E7ACA; Thu, 20 Dec 2007 19:46:20 +0400 (RET) Date: Thu, 20 Dec 2007 15:47:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [RFA] Remove defs.h #include in rs6000-tdep.h Message-ID: <20071220154620.GG6184@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="BwCQnh7xodEAoBMC" Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00338.txt.bz2 --BwCQnh7xodEAoBMC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 501 This is the only other #include of defs.h in a .h file that I could find, and I wouldn't mind a second look. I noticed that it was also missing an opaque declaration of struct frame_info, so I added it as well. 2007-12-20 Joel Brobecker * rs6000-tdep.h: Remove defs.h #include. (struct frame_info): Add opaque declaration. * Makefile.in (rs6000_tdep_h): Update dependencies. Tested by rebuilding on powerpc-aix. Does it look OK? Thanks, -- Joel --BwCQnh7xodEAoBMC Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="rs6000.diff" Content-length: 1152 Index: rs6000-tdep.h =================================================================== RCS file: /cvs/src/src/gdb/rs6000-tdep.h,v retrieving revision 1.7 diff -u -p -r1.7 rs6000-tdep.h --- rs6000-tdep.h 23 Aug 2007 18:08:37 -0000 1.7 +++ rs6000-tdep.h 20 Dec 2007 06:01:23 -0000 @@ -17,7 +17,8 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ -#include "defs.h" +/* Opaque declarations. */ +struct frame_info; extern int rs6000_software_single_step (struct frame_info *frame); Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.968 diff -u -p -r1.968 Makefile.in --- Makefile.in 20 Dec 2007 05:36:14 -0000 1.968 +++ Makefile.in 20 Dec 2007 05:59:46 -0000 @@ -855,7 +855,7 @@ reggroups_h = reggroups.h regset_h = regset.h remote_fileio_h = remote-fileio.h remote_h = remote.h -rs6000_tdep_h = rs6000-tdep.h $(defs_h) +rs6000_tdep_h = rs6000-tdep.h s390_tdep_h = s390-tdep.h scm_lang_h = scm-lang.h $(scm_tags_h) scm_tags_h = scm-tags.h --BwCQnh7xodEAoBMC--