From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Remove defs.h #include in rs6000-tdep.h
Date: Thu, 20 Dec 2007 16:37:00 -0000 [thread overview]
Message-ID: <200712201600.lBKG0OqG017293@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20071220154620.GG6184@adacore.com> (message from Joel Brobecker on Thu, 20 Dec 2007 19:46:20 +0400)
> Date: Thu, 20 Dec 2007 19:46:20 +0400
> From: Joel Brobecker <brobecker@adacore.com>
>
> This is the only other #include of defs.h in a .h file that I could find,
> and I wouldn't mind a second look.
Looks ok.
> I noticed that it was also missing an opaque declaration of struct
> frame_info, so I added it as well.
There is one in "defs.h", but it doesn't hurt.
> 2007-12-20 Joel Brobecker <brobecker@adacore.com>
>
> * rs6000-tdep.h: Remove defs.h #include.
> (struct frame_info): Add opaque declaration.
> * Makefile.in (rs6000_tdep_h): Update dependencies.
next prev parent reply other threads:[~2007-12-20 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 15:47 Joel Brobecker
2007-12-20 16:37 ` Mark Kettenis [this message]
2007-12-21 6:07 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712201600.lBKG0OqG017293@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox