[commit] remove opaque enum declaration in symtab.h

[commit] remove opaque enum declaration in symtab.h

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

This fixes the only other instance I could find of the use of an opaque
enum declaration.  The enum type is defined inside defs.h, so I simply
included this file, and removed the enum declaration.

2007-12-19  Joel Brobecker  <brobecker@adacore.com>

        * symtab.h: #include "defs.h".
        (enum language): Remove opaque declaration.
        * Makefile.in (symtab_h): Update dependencies.

Tested on x86-linux by rebuilding GDB.
Checked in.

-- 
Joel

[-- Attachment #2: symtab.h.diff --]
[-- Type: text/plain, Size: 1217 bytes --]

Index: symtab.h
===================================================================
RCS file: /cvs/src/src/gdb/symtab.h,v
retrieving revision 1.108
diff -u -p -r1.108 symtab.h
--- symtab.h	19 Oct 2007 12:26:34 -0000	1.108
+++ symtab.h	19 Dec 2007 13:16:54 -0000
@@ -22,6 +22,8 @@
 #if !defined (SYMTAB_H)
 #define SYMTAB_H 1
 
+#include "defs.h"
+
 /* Opaque declarations.  */
 struct ui_file;
 struct frame_info;
@@ -32,7 +34,6 @@ struct block;
 struct blockvector;
 struct axs_value;
 struct agent_expr;
-enum language;
 
 /* Some of the structures in this file are space critical.
    The space-critical structures are:
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.966
diff -u -p -r1.966 Makefile.in
--- Makefile.in	17 Dec 2007 17:49:28 -0000	1.966
+++ Makefile.in	19 Dec 2007 13:17:07 -0000
@@ -885,7 +885,7 @@ srec_h = srec.h
 stabsread_h = stabsread.h
 stack_h = stack.h
 symfile_h = symfile.h $(symtab_h)
-symtab_h = symtab.h
+symtab_h = symtab.h $(defs_h)
 target_h = target.h $(bfd_h) $(symtab_h) $(dcache_h) $(memattr_h) $(vec_h)
 target_descriptions_h = target-descriptions.h
 terminal_h = terminal.h

Re: [commit] remove opaque enum declaration in symtab.h

[Daniel Jacobowitz]

On Wed, Dec 19, 2007 at 05:25:46PM +0400, Joel Brobecker wrote:
> This fixes the only other instance I could find of the use of an opaque
> enum declaration.  The enum type is defined inside defs.h, so I simply
> included this file, and removed the enum declaration.
> 
> 2007-12-19  Joel Brobecker  <brobecker@adacore.com>
> 
>         * symtab.h: #include "defs.h".

FYI, this is not necessary; defs.h is always included first and
everything depends on it.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [commit] remove opaque enum declaration in symtab.h

[Joel Brobecker]

> > 2007-12-19  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         * symtab.h: #include "defs.h".
> 
> FYI, this is not necessary; defs.h is always included first and
> everything depends on it.

Should I remove it, then? We have other .h files that include defs.h,
perhaps we should take care of them too...

-- 
Joel

Re: [commit] remove opaque enum declaration in symtab.h

[Daniel Jacobowitz]

On Wed, Dec 19, 2007 at 06:08:31PM +0400, Joel Brobecker wrote:
> > > 2007-12-19  Joel Brobecker  <brobecker@adacore.com>
> > > 
> > >         * symtab.h: #include "defs.h".
> > 
> > FYI, this is not necessary; defs.h is always included first and
> > everything depends on it.
> 
> Should I remove it, then? We have other .h files that include defs.h,
> perhaps we should take care of them too...

IMO, yes, but it's not very important.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [commit] remove opaque enum declaration in symtab.h

[Mark Kettenis]

> Date: Wed, 19 Dec 2007 18:08:31 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> 
> > > 2007-12-19  Joel Brobecker  <brobecker@adacore.com>
> > > 
> > >         * symtab.h: #include "defs.h".
> > 
> > FYI, this is not necessary; defs.h is always included first and
> > everything depends on it.
> 
> Should I remove it, then? We have other .h files that include defs.h,
> perhaps we should take care of them too...

Yes please.

Mark

Re: [commit] remove opaque enum declaration in symtab.h

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

> > > > 2007-12-19  Joel Brobecker  <brobecker@adacore.com>
> > > > 
> > > >         * symtab.h: #include "defs.h".
> > > 
> > > FYI, this is not necessary; defs.h is always included first and
> > > everything depends on it.
> > 
> > Should I remove it, then? We have other .h files that include defs.h,
> > perhaps we should take care of them too...
> 
> Yes please.

Fixed with the attached patch.

2007-12-20  Joel Brobecker  <brobecker@adacore.com>

        * symtab.h: Remove "defs.h" #include.
        * Makefile.in (symtab_h): Update dependencies.

Thanks for the feedback.  I will send a patch for the remaining
unexpected includes.

-- 
Joel

[-- Attachment #2: defs.diff --]
[-- Type: text/plain, Size: 1008 bytes --]

Index: symtab.h
===================================================================
RCS file: /cvs/src/src/gdb/symtab.h,v
retrieving revision 1.109
diff -u -p -r1.109 symtab.h
--- symtab.h	19 Dec 2007 13:21:32 -0000	1.109
+++ symtab.h	20 Dec 2007 05:31:31 -0000
@@ -22,8 +22,6 @@
 #if !defined (SYMTAB_H)
 #define SYMTAB_H 1
 
-#include "defs.h"
-
 /* Opaque declarations.  */
 struct ui_file;
 struct frame_info;
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.967
diff -u -p -r1.967 Makefile.in
--- Makefile.in	19 Dec 2007 13:21:32 -0000	1.967
+++ Makefile.in	20 Dec 2007 05:31:48 -0000
@@ -885,7 +885,7 @@ srec_h = srec.h
 stabsread_h = stabsread.h
 stack_h = stack.h
 symfile_h = symfile.h $(symtab_h)
-symtab_h = symtab.h $(defs_h)
+symtab_h = symtab.h
 target_h = target.h $(bfd_h) $(symtab_h) $(dcache_h) $(memattr_h) $(vec_h)
 target_descriptions_h = target-descriptions.h
 terminal_h = terminal.h