From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27397 invoked by alias); 20 Dec 2007 05:40:34 -0000 Received: (qmail 27384 invoked by uid 22791); 20 Dec 2007 05:40:32 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Dec 2007 05:40:25 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2FB9B2A966D; Thu, 20 Dec 2007 00:40:24 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id L-ydJ+UfIS4o; Thu, 20 Dec 2007 00:40:24 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3760F2A966C; Thu, 20 Dec 2007 00:40:23 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 182A4E7ACA; Thu, 20 Dec 2007 09:40:15 +0400 (RET) Date: Thu, 20 Dec 2007 05:52:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [commit] remove opaque enum declaration in symtab.h Message-ID: <20071220054015.GF6154@adacore.com> References: <20071219132546.GC6154@adacore.com> <20071219140458.GB20359@caradoc.them.org> <20071219140831.GD6154@adacore.com> <200712191422.lBJEMU3J004356@brahms.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="osDK9TLjxFScVI/L" Content-Disposition: inline In-Reply-To: <200712191422.lBJEMU3J004356@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00328.txt.bz2 --osDK9TLjxFScVI/L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 651 > > > > 2007-12-19 Joel Brobecker > > > > > > > > * symtab.h: #include "defs.h". > > > > > > FYI, this is not necessary; defs.h is always included first and > > > everything depends on it. > > > > Should I remove it, then? We have other .h files that include defs.h, > > perhaps we should take care of them too... > > Yes please. Fixed with the attached patch. 2007-12-20 Joel Brobecker * symtab.h: Remove "defs.h" #include. * Makefile.in (symtab_h): Update dependencies. Thanks for the feedback. I will send a patch for the remaining unexpected includes. -- Joel --osDK9TLjxFScVI/L Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="defs.diff" Content-length: 1008 Index: symtab.h =================================================================== RCS file: /cvs/src/src/gdb/symtab.h,v retrieving revision 1.109 diff -u -p -r1.109 symtab.h --- symtab.h 19 Dec 2007 13:21:32 -0000 1.109 +++ symtab.h 20 Dec 2007 05:31:31 -0000 @@ -22,8 +22,6 @@ #if !defined (SYMTAB_H) #define SYMTAB_H 1 -#include "defs.h" - /* Opaque declarations. */ struct ui_file; struct frame_info; Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.967 diff -u -p -r1.967 Makefile.in --- Makefile.in 19 Dec 2007 13:21:32 -0000 1.967 +++ Makefile.in 20 Dec 2007 05:31:48 -0000 @@ -885,7 +885,7 @@ srec_h = srec.h stabsread_h = stabsread.h stack_h = stack.h symfile_h = symfile.h $(symtab_h) -symtab_h = symtab.h $(defs_h) +symtab_h = symtab.h target_h = target.h $(bfd_h) $(symtab_h) $(dcache_h) $(memattr_h) $(vec_h) target_descriptions_h = target-descriptions.h terminal_h = terminal.h --osDK9TLjxFScVI/L--