From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10662 invoked by alias); 19 Dec 2007 14:18:38 -0000 Received: (qmail 10651 invoked by uid 22791); 19 Dec 2007 14:18:37 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Dec 2007 14:18:31 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 8F3DB98151 for ; Wed, 19 Dec 2007 14:18:29 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 7982C9814F for ; Wed, 19 Dec 2007 14:18:29 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1J4zki-0005a5-LU for gdb-patches@sourceware.org; Wed, 19 Dec 2007 09:18:28 -0500 Date: Wed, 19 Dec 2007 14:23:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [commit] remove opaque enum declaration in symtab.h Message-ID: <20071219141828.GB21072@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20071219132546.GC6154@adacore.com> <20071219140458.GB20359@caradoc.them.org> <20071219140831.GD6154@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071219140831.GD6154@adacore.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00309.txt.bz2 On Wed, Dec 19, 2007 at 06:08:31PM +0400, Joel Brobecker wrote: > > > 2007-12-19 Joel Brobecker > > > > > > * symtab.h: #include "defs.h". > > > > FYI, this is not necessary; defs.h is always included first and > > everything depends on it. > > Should I remove it, then? We have other .h files that include defs.h, > perhaps we should take care of them too... IMO, yes, but it's not very important. -- Daniel Jacobowitz CodeSourcery