From: Joel Brobecker <brobecker@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] remove opaque enum declaration in symtab.h
Date: Thu, 20 Dec 2007 05:52:00 -0000 [thread overview]
Message-ID: <20071220054015.GF6154@adacore.com> (raw)
In-Reply-To: <200712191422.lBJEMU3J004356@brahms.sibelius.xs4all.nl>
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
> > > > 2007-12-19 Joel Brobecker <brobecker@adacore.com>
> > > >
> > > > * symtab.h: #include "defs.h".
> > >
> > > FYI, this is not necessary; defs.h is always included first and
> > > everything depends on it.
> >
> > Should I remove it, then? We have other .h files that include defs.h,
> > perhaps we should take care of them too...
>
> Yes please.
Fixed with the attached patch.
2007-12-20 Joel Brobecker <brobecker@adacore.com>
* symtab.h: Remove "defs.h" #include.
* Makefile.in (symtab_h): Update dependencies.
Thanks for the feedback. I will send a patch for the remaining
unexpected includes.
--
Joel
[-- Attachment #2: defs.diff --]
[-- Type: text/plain, Size: 1008 bytes --]
Index: symtab.h
===================================================================
RCS file: /cvs/src/src/gdb/symtab.h,v
retrieving revision 1.109
diff -u -p -r1.109 symtab.h
--- symtab.h 19 Dec 2007 13:21:32 -0000 1.109
+++ symtab.h 20 Dec 2007 05:31:31 -0000
@@ -22,8 +22,6 @@
#if !defined (SYMTAB_H)
#define SYMTAB_H 1
-#include "defs.h"
-
/* Opaque declarations. */
struct ui_file;
struct frame_info;
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.967
diff -u -p -r1.967 Makefile.in
--- Makefile.in 19 Dec 2007 13:21:32 -0000 1.967
+++ Makefile.in 20 Dec 2007 05:31:48 -0000
@@ -885,7 +885,7 @@ srec_h = srec.h
stabsread_h = stabsread.h
stack_h = stack.h
symfile_h = symfile.h $(symtab_h)
-symtab_h = symtab.h $(defs_h)
+symtab_h = symtab.h
target_h = target.h $(bfd_h) $(symtab_h) $(dcache_h) $(memattr_h) $(vec_h)
target_descriptions_h = target-descriptions.h
terminal_h = terminal.h
prev parent reply other threads:[~2007-12-20 5:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 13:30 Joel Brobecker
2007-12-19 14:08 ` Daniel Jacobowitz
2007-12-19 14:18 ` Joel Brobecker
2007-12-19 14:23 ` Daniel Jacobowitz
2007-12-19 14:51 ` Mark Kettenis
2007-12-20 5:52 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071220054015.GF6154@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox